From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T49Y1-00027F-IX for qemu-devel@nongnu.org; Wed, 22 Aug 2012 07:56:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T49Xz-0004Kh-Fr for qemu-devel@nongnu.org; Wed, 22 Aug 2012 07:56:33 -0400 Received: from mx.meyering.net ([88.168.87.75]:45304 helo=hx.meyering.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T49Xy-0004KV-Si for qemu-devel@nongnu.org; Wed, 22 Aug 2012 07:56:31 -0400 From: Jim Meyering Date: Wed, 22 Aug 2012 13:55:52 +0200 Message-Id: <1345636556-29008-2-git-send-email-jim@meyering.net> In-Reply-To: <1345636556-29008-1-git-send-email-jim@meyering.net> References: <1345636556-29008-1-git-send-email-jim@meyering.net> Subject: [Qemu-devel] [PATCHv3 1/5] qemu-ga: don't leak a file descriptor upon failed lockf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jim Meyering From: Jim Meyering Signed-off-by: Jim Meyering --- qemu-ga.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qemu-ga.c b/qemu-ga.c index 8f87621..26671fe 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -247,6 +247,9 @@ static bool ga_open_pidfile(const char *pidfile) pidfd = open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR); if (pidfd == -1 || lockf(pidfd, F_TLOCK, 0)) { g_critical("Cannot lock pid file, %s", strerror(errno)); + if (pidfd != -1) { + close(pidfd); + } return false; } -- 1.7.12