* [Qemu-devel] [PATCH for 1.2] ivshmem: fix memory_region_del_eventfd assertion failure
@ 2012-08-22 21:09 Paolo Bonzini
0 siblings, 0 replies; only message in thread
From: Paolo Bonzini @ 2012-08-22 21:09 UTC (permalink / raw)
To: qemu-devel; +Cc: aliguori, Cam Macdonnell
We do not register ioeventfds unless the IVSHMEM_IOEVENTFD feature
is set. The same feature must be checked before releasing the eventfds.
Regression introduced by commit 563027c (ivshmem: use EventNotifier and
memory API, 2012-07-05).
Reported-by: Cam Macdonnell <cam@cs.ualberta.ca>
Tested-by: Cam Macdonnell <cam@cs.ualberta.ca>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/ivshmem.c | 4 ++++
1 file modificato, 4 inserzioni(+)
diff --git a/hw/ivshmem.c b/hw/ivshmem.c
index b4d65a6..47f2a16 100644
--- a/hw/ivshmem.c
+++ b/hw/ivshmem.c
@@ -366,6 +366,10 @@ static void close_guest_eventfds(IVShmemState *s, int posn)
{
int i, guest_curr_max;
+ if (!ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) {
+ return;
+ }
+
guest_curr_max = s->peers[posn].nb_eventfds;
memory_region_transaction_begin();
--
1.7.11.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-08-22 21:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-22 21:09 [Qemu-devel] [PATCH for 1.2] ivshmem: fix memory_region_del_eventfd assertion failure Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).