From: Lei Li <lilei@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, eblake@redhat.com,
Lei Li <lilei@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 2/6] monitor: Adjust qmp_human_monitor_command to new MemCharDriver
Date: Thu, 23 Aug 2012 13:14:22 +0800 [thread overview]
Message-ID: <1345698866-19794-3-git-send-email-lilei@linux.vnet.ibm.com> (raw)
In-Reply-To: <1345698866-19794-1-git-send-email-lilei@linux.vnet.ibm.com>
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
monitor.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/monitor.c b/monitor.c
index 480f583..ab4650b 100644
--- a/monitor.c
+++ b/monitor.c
@@ -642,7 +642,13 @@ char *qmp_human_monitor_command(const char *command_line, bool has_cpu_index,
CharDriverState mchar;
memset(&hmp, 0, sizeof(hmp));
- qemu_chr_init_mem(&mchar);
+
+ /* Since the backend of MemCharDriver convert to a circular
+ * buffer with fixed size, so should indicate the init memory
+ * size.
+ *
+ * XXX: is 4096 as init memory enough for this? */
+ qemu_chr_init_mem(&mchar, 4096);
hmp.chr = &mchar;
old_mon = cur_mon;
--
1.7.7.6
next prev parent reply other threads:[~2012-08-23 5:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 5:14 [Qemu-devel] [RFC v2 ATCH 0/4] char: expose MemoryCharDriver to users and provide QMP interface Lei Li
2012-08-23 5:14 ` [Qemu-devel] [PATCH 1/6] qemu-char: Convert MemCharDriver to circular buffer Lei Li
2012-08-30 18:43 ` Luiz Capitulino
2012-08-23 5:14 ` Lei Li [this message]
2012-08-30 18:51 ` [Qemu-devel] [PATCH 2/6] monitor: Adjust qmp_human_monitor_command to new MemCharDriver Luiz Capitulino
2012-09-03 16:14 ` Lei Li
2012-09-03 16:21 ` Luiz Capitulino
2012-08-23 5:14 ` [Qemu-devel] [PATCH 3/6] QAPI: Introduce memchar_write QMP command Lei Li
2012-08-23 5:42 ` Eric Blake
2012-08-23 6:40 ` Lei Li
2012-08-31 7:26 ` Markus Armbruster
2012-08-30 19:17 ` Luiz Capitulino
2012-08-31 7:17 ` Markus Armbruster
2012-08-23 5:14 ` [Qemu-devel] [PATCH 4/6] QAPI: Introduce memchar_read " Lei Li
2012-08-23 5:46 ` Eric Blake
2012-08-23 7:30 ` Lei Li
2012-08-23 5:14 ` [Qemu-devel] [PATCH 5/6] Fix enumeration typo error Lei Li
2012-08-23 5:48 ` Eric Blake
2012-08-30 19:20 ` Luiz Capitulino
2012-08-31 6:52 ` Stefan Hajnoczi
2012-08-23 5:14 ` [Qemu-devel] [PATCH 6/6] Expose MemCharDriver via command line Lei Li
2012-08-31 7:02 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345698866-19794-3-git-send-email-lilei@linux.vnet.ibm.com \
--to=lilei@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).