From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4eXd-0006PF-98 for qemu-devel@nongnu.org; Thu, 23 Aug 2012 17:02:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4eXW-0000J9-RA for qemu-devel@nongnu.org; Thu, 23 Aug 2012 17:02:13 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:55230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4eXW-0000J0-KM for qemu-devel@nongnu.org; Thu, 23 Aug 2012 17:02:06 -0400 From: Stefan Weil Date: Thu, 23 Aug 2012 23:02:02 +0200 Message-Id: <1345755722-25229-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Weil , Hannes Reinecke Type casts from pointer to integer values must use uintptr_t instead of unsigned long. Otherwise the compiler complains on hosts with sizeof(pointer) != sizeof(long). The patch also replace magic number 32 by sizeof(info.serial_number) which has the same value but is better for code reviews. Signed-off-by: Stefan Weil --- hw/megasas.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/megasas.c b/hw/megasas.c index c35a15d..f2d6783 100644 --- a/hw/megasas.c +++ b/hw/megasas.c @@ -698,8 +698,8 @@ static int megasas_ctrl_get_info(MegasasState *s, MegasasCmd *cmd) } memcpy(info.product_name, "MegaRAID SAS 8708EM2", 20); - snprintf(info.serial_number, 32, "QEMU%08lx", - (unsigned long)s & 0xFFFFFFFF); + snprintf(info.serial_number, sizeof(info.serial_number), + "QEMU%08" PRIxPTR, (uintptr_t)s & 0xFFFFFFFF); snprintf(info.package_version, 0x60, "%s-QEMU", QEMU_VERSION); memcpy(info.image_component[0].name, "APP", 3); memcpy(info.image_component[0].version, MEGASAS_VERSION "-QEMU", 9); -- 1.7.10