From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4m31-0003Lb-Kb for qemu-devel@nongnu.org; Fri, 24 Aug 2012 01:03:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4m30-0001SU-EQ for qemu-devel@nongnu.org; Fri, 24 Aug 2012 01:03:07 -0400 From: Stefan Weil Date: Fri, 24 Aug 2012 07:03:03 +0200 Message-Id: <1345784583-25640-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH for 1.2] qemu-ga: Fix null pointer passed to unlink in failure branch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org Cc: Stefan Weil , Anthony Liguori , qemu-devel@nongnu.org Clang reports this warning: Null pointer passed as an argument to a 'nonnull' parameter Signed-off-by: Stefan Weil --- qemu-ga.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qemu-ga.c b/qemu-ga.c index 26671fe..7623079 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -438,7 +438,9 @@ static void become_daemon(const char *pidfile) return; fail: - unlink(pidfile); + if (pidfile) { + unlink(pidfile); + } g_critical("failed to daemonize"); exit(EXIT_FAILURE); #endif -- 1.7.10