From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4qXb-0003Sk-MR for qemu-devel@nongnu.org; Fri, 24 Aug 2012 05:51:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4qXa-000381-Jz for qemu-devel@nongnu.org; Fri, 24 Aug 2012 05:50:59 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:48876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4qXa-00037L-Ex for qemu-devel@nongnu.org; Fri, 24 Aug 2012 05:50:58 -0400 Received: by obbta14 with SMTP id ta14so3534267obb.4 for ; Fri, 24 Aug 2012 02:50:56 -0700 (PDT) From: Liu Ping Fan Date: Fri, 24 Aug 2012 17:49:18 +0800 Message-Id: <1345801763-24227-6-git-send-email-qemulist@gmail.com> In-Reply-To: <1345801763-24227-1-git-send-email-qemulist@gmail.com> References: <1345801763-24227-1-git-send-email-qemulist@gmail.com> Subject: [Qemu-devel] [PATCH 05/10] qdev: finalize of qbus, qdev will not the right place to free children List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Liu Ping Fan , Avi Kivity , Anthony Liguori From: Liu Ping Fan When breaking big lock, the child object can be hold by mmio-dispatch, and it is not right to free them when their parent gone. We will isolate and release the children by qdev_delete_subtree(), and let each object manage its own life cycle. Signed-off-by: Liu Ping Fan --- hw/qdev.c | 30 ++++++++++++------------------ 1 files changed, 12 insertions(+), 18 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 570f0bf..d6c8130 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -756,10 +756,8 @@ static void device_finalize(Object *obj) DeviceClass *dc = DEVICE_GET_CLASS(dev); if (dev->state == DEV_STATE_INITIALIZED) { - while (dev->num_child_bus) { - bus = QLIST_FIRST(&dev->child_bus); - qbus_free(bus); - } + + g_assert(QLIST_EMPTY(&dev->child_bus)); if (qdev_get_vmsd(dev)) { vmstate_unregister(dev, qdev_get_vmsd(dev), dev); } @@ -770,9 +768,8 @@ static void device_finalize(Object *obj) qemu_opts_del(dev->opts); } } - if (dev->parent_bus) { - bus_remove_child(dev->parent_bus, dev); - } + + g_assert((dev->parent_bus == NULL)); } static void device_class_base_init(ObjectClass *class, void *data) @@ -826,19 +823,16 @@ static void qbus_initfn(Object *obj) static void qbus_finalize(Object *obj) { BusState *bus = BUS(obj); - BusChild *kid; - while ((kid = QTAILQ_FIRST(&bus->children)) != NULL) { - DeviceState *dev = kid->child; - qdev_free(dev); - } - if (bus->parent) { - QLIST_REMOVE(bus, sibling); - bus->parent->num_child_bus--; - } else { - assert(bus != sysbus_get_default()); /* main_system_bus is never freed */ - qemu_unregister_reset(qbus_reset_all_fn, bus); + assert(bus != sysbus_get_default()); /* main_system_bus is never freed */ + /* just blind check, since bus->parent has been set to NULL */ + qemu_unregister_reset(qbus_reset_all_fn, bus); + if (bus->overlap != NULL) { + object_unref(OBJECT(bus->overlap)); } + assert(QTAILQ_EMPTY(&bus->children)); + /* have reset it to NULL, to prevent reader */ + assert((bus->parent == NULL)); g_free((char *)bus->name); } -- 1.7.4.4