[Qemu-devel] [PATCH] audio: previous audio buffer should be flushed

[Qemu-devel] [PATCH] audio: previous audio buffer should be flushed

[munkyu.im]

*** BLURB HERE ***

munkyu.im (1):
  audio: previous audio buffer should be flushed

 audio/winwaveaudio.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.7.4.1

[Qemu-devel] [PATCH] audio: previous audio buffer should be flushed

[munkyu.im]

Buffer must be flushed when audio out is paused, but Winwave audio backend has problem with this unlike other backends.
As a result, when user stop and restart audio files or something, the previous audio data are played in front of user expected sound.
So changes it to waveOutReset()
---
 audio/winwaveaudio.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/audio/winwaveaudio.c b/audio/winwaveaudio.c
index 663abb9..7de12a6 100644
--- a/audio/winwaveaudio.c
+++ b/audio/winwaveaudio.c
@@ -361,9 +361,9 @@ static int winwave_ctl_out (HWVoiceOut *hw, int cmd, ...)
 
     case VOICE_DISABLE:
         if (!wave->paused) {
-            mr = waveOutPause (wave->hwo);
+            mr = waveOutReset (wave->hwo);
             if (mr != MMSYSERR_NOERROR) {
-                winwave_logerr (mr, "waveOutPause");
+                winwave_logerr (mr, "waveOutReset");
             }
             else {
                 wave->paused = 1;
-- 
1.7.4.1

[Qemu-devel] [PATCH]] audio: previous audio buffer should be flushed

[munkyu.im]

Winwave audio backend has problem with pausing and restart audio out.
Unlike other backends, Winwave pausing API does not flush audio buffer.
As a result, the previous audio data are playedin front of
user expected sound when user restart audio.
So changes it to waveOutReset()

Signed-off-by: Munkyu Im <munkyu.im@samsung.com>
---
 audio/winwaveaudio.c |   12 +++---------
 1 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/audio/winwaveaudio.c b/audio/winwaveaudio.c
index 663abb9..72babbf 100644
--- a/audio/winwaveaudio.c
+++ b/audio/winwaveaudio.c
@@ -349,21 +349,15 @@ static int winwave_ctl_out (HWVoiceOut *hw, int cmd, ...)
             else {
                 hw->poll_mode = 0;
             }
-            if (wave->paused) {
-                mr = waveOutRestart (wave->hwo);
-                if (mr != MMSYSERR_NOERROR) {
-                    winwave_logerr (mr, "waveOutRestart");
-                }
-                wave->paused = 0;
-            }
+            wave->paused = 0;
         }
         return 0;
 
     case VOICE_DISABLE:
         if (!wave->paused) {
-            mr = waveOutPause (wave->hwo);
+            mr = waveOutReset (wave->hwo);
             if (mr != MMSYSERR_NOERROR) {
-                winwave_logerr (mr, "waveOutPause");
+                winwave_logerr (mr, "waveOutReset");
             }
             else {
                 wave->paused = 1;
-- 
1.7.4.1

Re: [Qemu-devel] [PATCH]] audio: previous audio buffer should be flushed

[malc]

On Tue, 28 Aug 2012, munkyu.im wrote:

> Winwave audio backend has problem with pausing and restart audio out.
> Unlike other backends, Winwave pausing API does not flush audio buffer.
> As a result, the previous audio data are playedin front of
> user expected sound when user restart audio.
> So changes it to waveOutReset()
> 
> Signed-off-by: Munkyu Im <munkyu.im@samsung.com>
> ---
>  audio/winwaveaudio.c |   12 +++---------
>  1 files changed, 3 insertions(+), 9 deletions(-)
> 

Thanks, applied with some cosmetics changes to the commit message.

-- 
mailto:av1474@comtv.ru