qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v2 for-1.2 0/2] stream: complete early if end of backing file is reached
Date: Tue, 28 Aug 2012 15:26:47 +0100	[thread overview]
Message-ID: <1346164009-30648-1-git-send-email-stefanha@linux.vnet.ibm.com> (raw)

Image streaming hangs if the backing image is smaller than the image file.  The
problem is that the image streaming loop makes no progress when
bdrv_co_is_allocated() returns 0 with pnum=0.  More details in the actual
patch.

I have also included a qemu-iotest to check this scenario.  It hangs when run
against qemu.git/master and passes when the patch is applied.

Stefan Hajnoczi (2):
  stream: complete early if end of backing file is reached
  qemu-iotests: add backing file smaller than image test case

 block/stream.c             |    6 ++++++
 tests/qemu-iotests/030     |   33 +++++++++++++++++++++++++++++++++
 tests/qemu-iotests/030.out |    4 ++--
 3 files changed, 41 insertions(+), 2 deletions(-)

-- 
1.7.10.4

             reply	other threads:[~2012-08-28 14:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28 14:26 Stefan Hajnoczi [this message]
2012-08-28 14:26 ` [Qemu-devel] [PATCH v2 for-1.2 1/2] stream: complete early if end of backing file is reached Stefan Hajnoczi
2012-08-28 14:37   ` Paolo Bonzini
2012-08-28 14:26 ` [Qemu-devel] [PATCH v2 for-1.2 2/2] qemu-iotests: add backing file smaller than image test case Stefan Hajnoczi
2012-08-28 14:38   ` Paolo Bonzini
2012-08-28 19:08 ` [Qemu-devel] [PATCH v2 for-1.2 0/2] stream: complete early if end of backing file is reached Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346164009-30648-1-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).