From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6d57-0005ly-6J for qemu-devel@nongnu.org; Wed, 29 Aug 2012 03:52:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6d51-0002vC-7x for qemu-devel@nongnu.org; Wed, 29 Aug 2012 03:52:57 -0400 Received: from mnementh.archaic.org.uk ([81.2.115.146]:43770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6d51-0002t6-18 for qemu-devel@nongnu.org; Wed, 29 Aug 2012 03:52:51 -0400 From: Peter Maydell Date: Wed, 29 Aug 2012 08:52:37 +0100 Message-Id: <1346226757-24968-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH for-1.2] hw/arm_gic.c: Define .class_size in arm_gic_info TypeInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Weil , Anthony Liguori , patches@linaro.org Add the missing .class_size definition to the arm_gic_info TypeInfo. This fixes the memory corruption and possible segfault that otherwise results when the class struct is allocated at too small a size and the class init function writes off the end of it. Reported-by: Adam Lackorzynski Signed-off-by: Peter Maydell --- Oops. I suspect this only crashes on 32 bit hosts because the class is only one field larger than its subclass, so on 64 bit systems we are probably only overwriting padding rather than anything important. For 1.2 since it fixes a segfault. hw/arm_gic.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index 186ac66..55871fa 100644 --- a/hw/arm_gic.c +++ b/hw/arm_gic.c @@ -703,6 +703,7 @@ static TypeInfo arm_gic_info = { .parent = TYPE_ARM_GIC_COMMON, .instance_size = sizeof(gic_state), .class_init = arm_gic_class_init, + .class_size = sizeof(ARMGICClass), }; static void arm_gic_register_types(void) -- 1.7.5.4