From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7iJk-0005Db-1M for qemu-devel@nongnu.org; Sat, 01 Sep 2012 03:40:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7iJj-0000AC-4a for qemu-devel@nongnu.org; Sat, 01 Sep 2012 03:40:31 -0400 From: Stefan Weil Date: Sat, 1 Sep 2012 09:40:26 +0200 Message-Id: <1346485226-26554-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH] qemu-sockets: Fix potential memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Stefan Weil , qemu-devel@nongnu.org The old code leaks variable 'peer'. Signed-off-by: Stefan Weil --- qemu-sockets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Report from smatch: qemu-sockets.c:404 inet_dgram_opts(101) warn: variable dereferenced before check 'peer' (see line 401) It looks like this warning does not make sense, but nevertheless it helped me to discover the leak. Regards, Stefan Weil diff --git a/qemu-sockets.c b/qemu-sockets.c index 361d890..037775b 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -353,7 +353,7 @@ int inet_dgram_opts(QemuOpts *opts) if (0 != (rc = getaddrinfo(addr, port, &ai, &local))) { fprintf(stderr,"getaddrinfo(%s,%s): %s\n", addr, port, gai_strerror(rc)); - return -1; + goto err; } /* create socket */ -- 1.7.10