From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7jfF-0001d9-H4 for qemu-devel@nongnu.org; Sat, 01 Sep 2012 05:06:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7jfE-0007Bn-3l for qemu-devel@nongnu.org; Sat, 01 Sep 2012 05:06:49 -0400 From: Stefan Weil Date: Sat, 1 Sep 2012 11:06:45 +0200 Message-Id: <1346490405-18889-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH] block/curl: Fix wrong free statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-trivial@nongnu.org, Stefan Weil , qemu-devel@nongnu.org Report from smatch: block/curl.c:546 curl_close(21) info: redundant null check on s->url calling free() The check was redundant, and free was also wrong because the memory was allocated using g_strdup. Signed-off-by: Stefan Weil --- block/curl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/curl.c b/block/curl.c index e7c3634..c1074cd 100644 --- a/block/curl.c +++ b/block/curl.c @@ -542,8 +542,7 @@ static void curl_close(BlockDriverState *bs) } if (s->multi) curl_multi_cleanup(s->multi); - if (s->url) - free(s->url); + g_free(s->url); } static int64_t curl_getlength(BlockDriverState *bs) -- 1.7.10