From: Stefan Weil <sw@weilnetz.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] json-parser: Fix potential NULL pointer segfault
Date: Sat, 1 Sep 2012 12:52:58 +0200 [thread overview]
Message-ID: <1346496778-15014-1-git-send-email-sw@weilnetz.de> (raw)
Report from smatch:
json-parser.c:474 parse_object(62) error: potential null derefence 'dict'.
json-parser.c:553 parse_array(75) error: potential null derefence 'list'.
Label out can be called with list == NULL.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
json-parser.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/json-parser.c b/json-parser.c
index 457291b..c31c759 100644
--- a/json-parser.c
+++ b/json-parser.c
@@ -471,7 +471,9 @@ static QObject *parse_object(JSONParserContext *ctxt, va_list *ap)
out:
parser_context_restore(ctxt, saved_ctxt);
- QDECREF(dict);
+ if (dict) {
+ QDECREF(dict);
+ }
return NULL;
}
@@ -550,7 +552,9 @@ static QObject *parse_array(JSONParserContext *ctxt, va_list *ap)
out:
parser_context_restore(ctxt, saved_ctxt);
- QDECREF(list);
+ if (list) {
+ QDECREF(list);
+ }
return NULL;
}
--
1.7.10
next reply other threads:[~2012-09-01 10:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 10:52 Stefan Weil [this message]
2012-09-03 16:41 ` [Qemu-devel] [PATCH] json-parser: Fix potential NULL pointer segfault Luiz Capitulino
2012-09-03 16:53 ` Stefan Weil
2012-09-03 17:14 ` Stefan Weil
2012-09-03 17:54 ` Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2012-09-03 19:19 Stefan Weil
2012-09-03 20:50 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346496778-15014-1-git-send-email-sw@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).