From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8cGt-00049l-Dz for qemu-devel@nongnu.org; Mon, 03 Sep 2012 15:25:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8cGs-0006vh-D1 for qemu-devel@nongnu.org; Mon, 03 Sep 2012 15:25:19 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:60511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8cGs-0006vA-1E for qemu-devel@nongnu.org; Mon, 03 Sep 2012 15:25:18 -0400 From: Stefan Weil Date: Mon, 3 Sep 2012 21:25:16 +0200 Message-Id: <1346700316-26625-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH] audio: Fix warning from static code analysis List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Malc Cc: Stefan Weil , qemu-devel@nongnu.org smatch report: audio/audio_template.h:416 AUD_open_out(18) warn: variable dereferenced before check 'as' (see line 414) Moving the ldebug statement after the statement which checks 'as' fixes that warning. Signed-off-by: Stefan Weil --- This patch fails when checked by checkpatch.pl because it preserves the coding style used for QEMU audio code. Please apply the patch after QEMU 1.2 was released. Thanks, Stefan Weil audio/audio_template.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/audio/audio_template.h b/audio/audio_template.h index 519432a..16f7880 100644 --- a/audio/audio_template.h +++ b/audio/audio_template.h @@ -410,15 +410,15 @@ SW *glue (AUD_open_, TYPE) ( SW *old_sw = NULL; #endif - ldebug ("open %s, freq %d, nchannels %d, fmt %d\n", - name, as->freq, as->nchannels, as->fmt); - if (audio_bug (AUDIO_FUNC, !card || !name || !callback_fn || !as)) { dolog ("card=%p name=%p callback_fn=%p as=%p\n", card, name, callback_fn, as); goto fail; } + ldebug ("open %s, freq %d, nchannels %d, fmt %d\n", + name, as->freq, as->nchannels, as->fmt); + if (audio_bug (AUDIO_FUNC, audio_validate_settings (as))) { audio_print_settings (as); goto fail; -- 1.7.10