* [Qemu-devel] [PATCH] kvm: Fix warning from static code analysis
@ 2012-09-03 20:40 Stefan Weil
2012-09-03 21:10 ` Peter Maydell
2012-09-05 9:36 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2012-09-03 20:40 UTC (permalink / raw)
To: qemu-trivial; +Cc: Stefan Weil, qemu-devel, kvm
Report from smatch:
kvm-all.c:1373 kvm_init(135) warn:
variable dereferenced before check 's' (see line 1360)
's' cannot by NULL (it was alloced using g_malloc0), so there is no need
to check it here.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
kvm-all.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 34b02c1..20b980d 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -1370,13 +1370,11 @@ int kvm_init(void)
return 0;
err:
- if (s) {
- if (s->vmfd >= 0) {
- close(s->vmfd);
- }
- if (s->fd != -1) {
- close(s->fd);
- }
+ if (s->vmfd >= 0) {
+ close(s->vmfd);
+ }
+ if (s->fd != -1) {
+ close(s->fd);
}
g_free(s);
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] kvm: Fix warning from static code analysis
2012-09-03 20:40 [Qemu-devel] [PATCH] kvm: Fix warning from static code analysis Stefan Weil
@ 2012-09-03 21:10 ` Peter Maydell
2012-09-05 9:36 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2012-09-03 21:10 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel, kvm
On 3 September 2012 21:40, Stefan Weil <sw@weilnetz.de> wrote:
> Report from smatch:
>
> kvm-all.c:1373 kvm_init(135) warn:
> variable dereferenced before check 's' (see line 1360)
>
> 's' cannot by NULL (it was alloced using g_malloc0), so there is no need
> to check it here.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] kvm: Fix warning from static code analysis
2012-09-03 20:40 [Qemu-devel] [PATCH] kvm: Fix warning from static code analysis Stefan Weil
2012-09-03 21:10 ` Peter Maydell
@ 2012-09-05 9:36 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-09-05 9:36 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel, kvm
On Mon, Sep 03, 2012 at 10:40:40PM +0200, Stefan Weil wrote:
> Report from smatch:
>
> kvm-all.c:1373 kvm_init(135) warn:
> variable dereferenced before check 's' (see line 1360)
>
> 's' cannot by NULL (it was alloced using g_malloc0), so there is no need
> to check it here.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> kvm-all.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-05 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-03 20:40 [Qemu-devel] [PATCH] kvm: Fix warning from static code analysis Stefan Weil
2012-09-03 21:10 ` Peter Maydell
2012-09-05 9:36 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).