From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8dgh-0006no-Sm for qemu-devel@nongnu.org; Mon, 03 Sep 2012 16:56:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8dgh-0001Dj-3u for qemu-devel@nongnu.org; Mon, 03 Sep 2012 16:56:03 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:49450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8dgg-0001C0-Th for qemu-devel@nongnu.org; Mon, 03 Sep 2012 16:56:03 -0400 From: Stefan Weil Date: Mon, 3 Sep 2012 22:56:00 +0200 Message-Id: <1346705760-11648-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH] hw/wm8750: Fix potential buffer overflow List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrzej Zaborowski Cc: Stefan Weil , qemu-devel@nongnu.org Report from smatch: hw/wm8750.c:369 wm8750_tx(12) error: buffer overflow 's->i2c_data' 2 <= 2 It looks like the preprocessor statements were simply misplaced. Replace also __FUNCTION__ by __func__ to please checkpatch.pl. Signed-off-by: Stefan Weil --- hw/wm8750.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/wm8750.c b/hw/wm8750.c index 11bcec3..44f138f 100644 --- a/hw/wm8750.c +++ b/hw/wm8750.c @@ -361,10 +361,10 @@ static int wm8750_tx(I2CSlave *i2c, uint8_t data) uint16_t value; if (s->i2c_len >= 2) { - printf("%s: long message (%i bytes)\n", __FUNCTION__, s->i2c_len); #ifdef VERBOSE - return 1; + printf("%s: long message (%i bytes)\n", __func__, s->i2c_len); #endif + return 1; } s->i2c_data[s->i2c_len ++] = data; if (s->i2c_len != 2) -- 1.7.10