From: "Benoît Canet" <benoit@irqsave.net>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com,
blauwirbel@gmail.com, pbonzini@redhat.com, eblake@redhat.com,
xiawenc@linux.vnet.ibm.com, "Benoît Canet" <benoit@irqsave.net>
Subject: [Qemu-devel] [PATCH V8 0/2] Add JSON output to qemu-img info
Date: Wed, 5 Sep 2012 13:09:00 +0200 [thread overview]
Message-ID: <1346843342-31708-1-git-send-email-benoit@irqsave.net> (raw)
This patchset add a JSON output mode to the qemu-img info command.
It's a rewrite from scratch of the original patchset by Wenchao Xia
following Anthony Liguori advices on JSON formating.
the --output=(json|human) option is now mandatory on the command line.
Benoît Canet (3):
qapi: Add SnapshotInfo.
qapi: Add ImageInfo.
qemu-img: Add json output option to the info command.
in v2:
eblake: make some field optionals
squash the two qapi patchs together
fix a typo on vm_clock_nsec
bcanet: fix a potential memory leak
in v3:
lcapitulino:
remove unneeded test
put '\n' at the end of json in printf statement
drop the uneeded head pointer in collect_snapshots
in v4:
Wenchao Xia && Kevin Wolf: -Refactor to separate rate ImageInfo
collection from human printing.
Kevin Wolf: -Use --output=(json|human).
-make the two choice exclusive and print a message
if none is specified.
-cosmetic '=' alignement in collect snapshots.
Benoît Canet: -add full-backing-filename to the ImageInfo structure
(needed for human printing)
-make ImageInfo->actual_size optional depending on the
context.
in v5:
Eric Blake: -use a constant for getopt parsing to avoid future
short options collision.
-make the command default to --output=human.
-fix spurious whitespace change.
-split vm-clock-nsec in two fields vm-clock-sec and
vm-clock-nsec.
-declare JSON structure as "Since 1.3"
in v6:
Blue Swirl: -Add missing const in getopt structure declaration.
Eric Blake: -Remove spurious undef.
-Use an enum instead of two boolean.
in v7:
Kevin Wolf: -Add missing documentation.
-Change bogus comment about chained lists support in qapi.
-Remove collect_backing_file_format and use bs->backing_format instead.
-Remove uneeded if.
-Change bogus printing logic for backing file format.
-Rename Format enum to OutputFormat.
-Use OFORMAT_HUMAN by default and get rid of uneeded else branch
-Use error_report insted of fprintf.
-Use a switch instead of ifs.
Benoît Canet: Rename FORMAT_HUMAN and FORMAT_JSON to OFORMAT_JSON and OFORMAT_HUMAN
in v8:
Kevin Wolf: -Check bs->backing_format[0] value to conditionaly include the format.
-print the backing format if available in human output.
-Move g_new0 down so we don't have the free it on error.
-better documentation via @code usage.
Benoît Canet (2):
qapi: Add SnapshotInfo and ImageInfo.
qemu-img: Add json output option to the info command.
Makefile | 3 +-
qapi-schema.json | 64 +++++++++++++++
qemu-img-cmds.hx | 4 +-
qemu-img.c | 236 ++++++++++++++++++++++++++++++++++++++++++++----------
qemu-img.texi | 5 +-
5 files changed, 263 insertions(+), 49 deletions(-)
--
1.7.9.5
next reply other threads:[~2012-09-05 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 11:09 Benoît Canet [this message]
2012-09-05 11:09 ` [Qemu-devel] [PATCH V8 1/2] qapi: Add SnapshotInfo and ImageInfo Benoît Canet
2012-09-05 11:09 ` [Qemu-devel] [PATCH V8 2/2] qemu-img: Add json output option to the info command Benoît Canet
2012-09-07 13:15 ` [Qemu-devel] [PATCH V8 0/2] Add JSON output to qemu-img info Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346843342-31708-1-git-send-email-benoit@irqsave.net \
--to=benoit@irqsave.net \
--cc=blauwirbel@gmail.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).