From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9Knt-0002H5-9P for qemu-devel@nongnu.org; Wed, 05 Sep 2012 14:58:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9Knp-0001dO-LT for qemu-devel@nongnu.org; Wed, 05 Sep 2012 14:58:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9Knp-0001dI-DU for qemu-devel@nongnu.org; Wed, 05 Sep 2012 14:58:17 -0400 From: Luiz Capitulino Date: Wed, 5 Sep 2012 15:58:36 -0300 Message-Id: <1346871526-25342-10-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1346871526-25342-1-git-send-email-lcapitulino@redhat.com> References: <1346871526-25342-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 09/19] qapi: Fix potential NULL pointer segfault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@us.ibm.com Cc: Stefan Weil , qemu-devel@nongnu.org From: Stefan Weil Report from smatch: qapi-visit.c:1640 visit_type_BlockdevAction(8) error: we previously assumed 'obj' could be null (see line 1639) qapi-visit.c:2432 visit_type_NetClientOptions(8) error: we previously assumed 'obj' could be null (see line 2431) Signed-off-by: Stefan Weil Reviewed-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- scripts/qapi-visit.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index cbec24d..e2093e8 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi-visit.py @@ -157,7 +157,7 @@ void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error ** if (!error_is_set(errp)) { visit_start_struct(m, (void **)obj, "%(name)s", name, sizeof(%(name)s), &err); if (!err) { - if (!obj || *obj) { + if (obj && *obj) { visit_type_%(name)sKind(m, &(*obj)->kind, "type", &err); if (!err) { switch ((*obj)->kind) { -- 1.7.11.2.249.g31c7954.dirty