From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9Kns-0002E2-Bq for qemu-devel@nongnu.org; Wed, 05 Sep 2012 14:58:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9Knr-0001dz-9b for qemu-devel@nongnu.org; Wed, 05 Sep 2012 14:58:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9Knr-0001do-1j for qemu-devel@nongnu.org; Wed, 05 Sep 2012 14:58:19 -0400 From: Luiz Capitulino Date: Wed, 5 Sep 2012 15:58:37 -0300 Message-Id: <1346871526-25342-11-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1346871526-25342-1-git-send-email-lcapitulino@redhat.com> References: <1346871526-25342-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 10/19] json-parser: Fix potential NULL pointer segfault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@us.ibm.com Cc: Stefan Weil , qemu-devel@nongnu.org From: Stefan Weil Report from smatch: json-parser.c:474 parse_object(62) error: potential null derefence 'dict'. json-parser.c:553 parse_array(75) error: potential null derefence 'list'. Label 'out' in json-parser.c can be called with list == NULL which is passed to QDECREF. Modify QDECREF to handle a NULL argument (inline function qobject_decref already handles them, too). Signed-off-by: Stefan Weil Signed-off-by: Luiz Capitulino --- qobject.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qobject.h b/qobject.h index d42386d..9124649 100644 --- a/qobject.h +++ b/qobject.h @@ -71,7 +71,7 @@ typedef struct QObject { /* High-level interface for qobject_decref() */ #define QDECREF(obj) \ - qobject_decref(QOBJECT(obj)) + qobject_decref(obj ? QOBJECT(obj) : NULL) /* Initialize an object to default values */ #define QOBJECT_INIT(obj, qtype_type) \ -- 1.7.11.2.249.g31c7954.dirty