From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Anthony Liguori" <anthony@codemonkey.ws>
Subject: [Qemu-devel] [PATCH 0/5] i386: cpu: remove duplicate feature names
Date: Thu, 6 Sep 2012 17:05:34 -0300 [thread overview]
Message-ID: <1346961939-32338-1-git-send-email-ehabkost@redhat.com> (raw)
The problem:
- Some features are report at the same time on both CPUID[1].EDX and
CPUID[8000_0001].EDX on AMD CPUs (e.g. fpu, tsc, msr, pae, mmx).
- "-cpu <model>,+feature" should enable the bit only on CPUID[1] if
it's not an AMD CPU, but it should enable the bit on both CPUID[1] and
CPUID[8000_0001] if it's an AMD CPU.
- The same should happen when implementing CPU properties: setting the
property that enables a feature should set the duplicate CPUID[8000_0001].EDX
bit only if CPU vendor is AMD.
Reference: http://article.gmane.org/gmane.comp.emulators.qemu/166024
The solution implemented by this series is:
- On the CPU model table and while parsing CPU options/properties, set the bit
only on CPUID[1] (the x86_def_t.features field).
- When finishing initialization of the CPU cpuid fields, duplicate those
feature bits on cpuid_ext2_features if and only if the CPU vendor is AMD.
This series depends on the "x86 CPU patches that didn't get into 1.2" series:
http://article.gmane.org/gmane.comp.emulators.qemu/168633
Message-Id: <1346877673-9136-1-git-send-email-ehabkost@redhat.com>
Eduardo Habkost (5):
i386: kvm: bit 10 of CPUID[8000_0001].EDX is reserved
i386: kvm: use a #define for the set of alias feature bits
i386: cpu: replace EXT2_FEATURE_MASK with CPUID_EXT2_AMD_ALIASES
i386: cpu: eliminate duplicate feature names
i386: -cpu help: remove reference to specific CPUID leaves/registers
target-i386/cpu.c | 59 +++++++++++++++++++++++++++++++++++--------------------
target-i386/cpu.h | 12 +++++++++++
target-i386/kvm.c | 2 +-
3 files changed, 51 insertions(+), 22 deletions(-)
--
1.7.11.4
next reply other threads:[~2012-09-06 20:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 20:05 Eduardo Habkost [this message]
2012-09-06 20:05 ` [Qemu-devel] [PATCH 1/5] i386: kvm: bit 10 of CPUID[8000_0001].EDX is reserved Eduardo Habkost
2012-09-11 19:51 ` Don Slutz
2012-09-06 20:05 ` [Qemu-devel] [PATCH 2/5] i386: kvm: use a #define for the set of alias feature bits Eduardo Habkost
2012-09-11 19:51 ` Don Slutz
2012-09-06 20:05 ` [Qemu-devel] [PATCH 3/5] i386: cpu: replace EXT2_FEATURE_MASK with CPUID_EXT2_AMD_ALIASES Eduardo Habkost
2012-09-11 19:53 ` Don Slutz
2012-09-06 20:05 ` [Qemu-devel] [PATCH 4/5] i386: cpu: eliminate duplicate feature names Eduardo Habkost
2012-09-11 19:53 ` Don Slutz
2012-09-06 20:05 ` [Qemu-devel] [PATCH 5/5] i386: -cpu help: remove reference to specific CPUID leaves/registers Eduardo Habkost
2012-09-11 19:54 ` Don Slutz
2012-09-26 13:33 ` [Qemu-devel] [PATCH 0/5] i386: cpu: remove duplicate feature names Igor Mammedov
2012-09-30 12:19 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346961939-32338-1-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).