From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: target-devel <target-devel@vger.kernel.org>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
kvm-devel <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel <qemu-devel@nongnu.org>,
Zhi Yong Wu <wuzhy@cn.ibm.com>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
Hannes Reinecke <hare@suse.de>,
Paolo Bonzini <pbonzini@redhat.com>,
lf-virt <virtualization@lists.linux-foundation.org>,
Christoph Hellwig <hch@lst.de>
Subject: [Qemu-devel] [PATCH 2/5] vhost: Pass device path to vhost_dev_init()
Date: Fri, 7 Sep 2012 06:48:16 +0000 [thread overview]
Message-ID: <1347000499-28701-3-git-send-email-nab@linux-iscsi.org> (raw)
In-Reply-To: <1347000499-28701-1-git-send-email-nab@linux-iscsi.org>
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
The path to /dev/vhost-net is currently hardcoded in vhost_dev_init().
This needs to be changed so that /dev/vhost-scsi can be used. Pass in
the device path instead of hardcoding it.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
---
hw/vhost.c | 5 +++--
hw/vhost.h | 3 ++-
hw/vhost_net.c | 2 +-
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/vhost.c b/hw/vhost.c
index 0fd8da8..d0ce5aa 100644
--- a/hw/vhost.c
+++ b/hw/vhost.c
@@ -747,14 +747,15 @@ static void vhost_eventfd_del(MemoryListener *listener,
{
}
-int vhost_dev_init(struct vhost_dev *hdev, int devfd, bool force)
+int vhost_dev_init(struct vhost_dev *hdev, int devfd, const char *devpath,
+ bool force)
{
uint64_t features;
int r;
if (devfd >= 0) {
hdev->control = devfd;
} else {
- hdev->control = open("/dev/vhost-net", O_RDWR);
+ hdev->control = open(devpath, O_RDWR);
if (hdev->control < 0) {
return -errno;
}
diff --git a/hw/vhost.h b/hw/vhost.h
index 80e64df..0c47229 100644
--- a/hw/vhost.h
+++ b/hw/vhost.h
@@ -44,7 +44,8 @@ struct vhost_dev {
bool force;
};
-int vhost_dev_init(struct vhost_dev *hdev, int devfd, bool force);
+int vhost_dev_init(struct vhost_dev *hdev, int devfd, const char *devpath,
+ bool force);
void vhost_dev_cleanup(struct vhost_dev *hdev);
bool vhost_dev_query(struct vhost_dev *hdev, VirtIODevice *vdev);
int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev);
diff --git a/hw/vhost_net.c b/hw/vhost_net.c
index ecaa22d..df2c4a3 100644
--- a/hw/vhost_net.c
+++ b/hw/vhost_net.c
@@ -109,7 +109,7 @@ struct vhost_net *vhost_net_init(NetClientState *backend, int devfd,
(1 << VHOST_NET_F_VIRTIO_NET_HDR);
net->backend = r;
- r = vhost_dev_init(&net->dev, devfd, force);
+ r = vhost_dev_init(&net->dev, devfd, "/dev/vhost-net", force);
if (r < 0) {
goto fail;
}
--
1.7.2.5
next prev parent reply other threads:[~2012-09-07 6:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 6:48 [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target Nicholas A. Bellinger
2012-09-07 6:48 ` [Qemu-devel] [PATCH 1/5] monitor: Rename+move net_handle_fd_param -> monitor_handle_fd_param Nicholas A. Bellinger
2012-09-07 6:48 ` Nicholas A. Bellinger [this message]
2012-09-07 6:48 ` [Qemu-devel] [PATCH 3/5] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost Nicholas A. Bellinger
2012-09-07 6:48 ` [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi Nicholas A. Bellinger
2012-09-07 16:00 ` Paolo Bonzini
2012-09-07 19:23 ` Nicholas A. Bellinger
2012-09-07 20:30 ` Paolo Bonzini
2012-09-08 22:40 ` Michael S. Tsirkin
2012-09-10 6:16 ` Paolo Bonzini
2012-09-10 6:24 ` Michael S. Tsirkin
2012-09-10 6:42 ` Paolo Bonzini
2012-09-10 6:49 ` Michael S. Tsirkin
2012-09-11 13:46 ` Anthony Liguori
2012-09-11 15:07 ` Michael S. Tsirkin
2012-09-13 22:27 ` Nicholas A. Bellinger
2012-09-14 6:45 ` Paolo Bonzini
2012-09-14 12:34 ` Michael S. Tsirkin
2012-09-14 12:50 ` Michael S. Tsirkin
2012-09-07 6:48 ` [Qemu-devel] [PATCH 5/5] virtio-scsi: Set max_target=0 during vhost-scsi operation Nicholas A. Bellinger
2012-09-11 4:36 ` [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target Asias He
2012-09-13 20:12 ` Nicholas A. Bellinger
2012-09-14 8:21 ` Paolo Bonzini
2013-01-17 16:43 ` Michael S. Tsirkin
2013-01-17 21:07 ` Nicholas A. Bellinger
2013-01-21 8:50 ` Michael S. Tsirkin
2013-04-02 3:28 ` Wenchao Xia
2013-04-02 5:07 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347000499-28701-3-git-send-email-nab@linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=aliguori@linux.vnet.ibm.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wuzhy@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).