From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH v2 6/9] tcg/optimize: swap brcond/setcond arguments when possible
Date: Fri, 7 Sep 2012 15:16:29 +0200 [thread overview]
Message-ID: <1347023792-24045-7-git-send-email-aurelien@aurel32.net> (raw)
In-Reply-To: <1347023792-24045-1-git-send-email-aurelien@aurel32.net>
brcond and setcond ops are not commutative, but it's easy to compute the
new condition after swapping the arguments. Try to always put the constant
argument in second position like for commutative ops, to help backends to
generate better code.
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
tcg/optimize.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index 1698ba3..7debc8a 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -318,6 +318,24 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr,
args[2] = tmp;
}
break;
+ CASE_OP_32_64(brcond):
+ if (temps[args[0]].state == TCG_TEMP_CONST
+ && temps[args[1]].state != TCG_TEMP_CONST) {
+ tmp = args[0];
+ args[0] = args[1];
+ args[1] = tmp;
+ args[2] = tcg_swap_cond(args[2]);
+ }
+ break;
+ CASE_OP_32_64(setcond):
+ if (temps[args[1]].state == TCG_TEMP_CONST
+ && temps[args[2]].state != TCG_TEMP_CONST) {
+ tmp = args[1];
+ args[1] = args[2];
+ args[2] = tmp;
+ args[3] = tcg_swap_cond(args[3]);
+ }
+ break;
default:
break;
}
--
1.7.10.4
next prev parent reply other threads:[~2012-09-07 13:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 13:16 [Qemu-devel] [PATCH v2 0/9] Improve TCG optimizer Aurelien Jarno
2012-09-07 13:16 ` [Qemu-devel] [PATCH v2 1/9] tcg: improve profiler Aurelien Jarno
2012-09-07 13:16 ` [Qemu-devel] [PATCH v2 2/9] tcg/optimize: split expression simplification Aurelien Jarno
2012-09-07 13:16 ` [Qemu-devel] [PATCH v2 3/9] tcg/optimize: simplify or/xor r, a, 0 cases Aurelien Jarno
2012-09-07 13:16 ` [Qemu-devel] [PATCH v2 4/9] tcg/optimize: simplify and " Aurelien Jarno
2012-09-07 13:16 ` [Qemu-devel] [PATCH v2 5/9] tcg/optimize: simplify shift/rot r, 0, a => movi r, " Aurelien Jarno
2012-09-07 13:16 ` Aurelien Jarno [this message]
2012-09-07 13:16 ` [Qemu-devel] [PATCH v2 7/9] tcg/optimize: add constant folding for setcond Aurelien Jarno
2012-09-07 13:16 ` [Qemu-devel] [PATCH v2 8/9] tcg/optimize: add constant folding for brcond Aurelien Jarno
2012-09-07 13:16 ` [Qemu-devel] [PATCH v2 9/9] tcg/optimize: fix if/else/break coding style Aurelien Jarno
2012-09-08 8:18 ` [Qemu-devel] [PATCH v2 0/9] Improve TCG optimizer Blue Swirl
2012-09-08 9:01 ` Aurelien Jarno
2012-09-08 9:06 ` Blue Swirl
2012-09-08 9:12 ` Aurelien Jarno
2012-09-08 9:29 ` Blue Swirl
2012-09-08 9:35 ` Aurelien Jarno
2012-09-10 13:55 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347023792-24045-7-git-send-email-aurelien@aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).