From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH 12/12] vga: cleanup after pci_vga_init() conversion
Date: Sat, 8 Sep 2012 13:26:24 +0200 [thread overview]
Message-ID: <1347103584-20598-13-git-send-email-aurelien@aurel32.net> (raw)
In-Reply-To: <1347103584-20598-1-git-send-email-aurelien@aurel32.net>
Now that all machines call pci_vga_init(), some unused code can be
removed.
Cc: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
hw/cirrus_vga.c | 6 ------
hw/vga-pci.c | 6 ------
hw/vga-pci.h | 12 ------------
hw/vmware_vga.c | 1 -
hw/vmware_vga.h | 15 ---------------
sysemu.h | 4 ----
6 files changed, 44 deletions(-)
delete mode 100644 hw/vga-pci.h
delete mode 100644 hw/vmware_vga.h
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index e8dcc6b..5d1d42f 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -28,7 +28,6 @@
*/
#include "hw.h"
#include "pci.h"
-#include "vga-pci.h"
#include "console.h"
#include "vga_int.h"
#include "loader.h"
@@ -2963,11 +2962,6 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev)
return 0;
}
-DeviceState *pci_cirrus_vga_init(PCIBus *bus)
-{
- return &pci_create_simple(bus, -1, "cirrus-vga")->qdev;
-}
-
static void cirrus_vga_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
diff --git a/hw/vga-pci.c b/hw/vga-pci.c
index 992ffd9..996d47f 100644
--- a/hw/vga-pci.c
+++ b/hw/vga-pci.c
@@ -24,7 +24,6 @@
#include "hw.h"
#include "console.h"
#include "pci.h"
-#include "vga-pci.h"
#include "vga_int.h"
#include "pixel_ops.h"
#include "qemu-timer.h"
@@ -70,11 +69,6 @@ static int pci_std_vga_initfn(PCIDevice *dev)
return 0;
}
-DeviceState *pci_std_vga_init(PCIBus *bus)
-{
- return &pci_create_simple(bus, -1, "VGA")->qdev;
-}
-
static Property vga_pci_properties[] = {
DEFINE_PROP_UINT32("vgamem_mb", PCIVGAState, vga.vram_size_mb, 16),
DEFINE_PROP_END_OF_LIST(),
diff --git a/hw/vga-pci.h b/hw/vga-pci.h
deleted file mode 100644
index d111cdc..0000000
--- a/hw/vga-pci.h
+++ /dev/null
@@ -1,12 +0,0 @@
-#ifndef VGA_PCI_H
-#define VGA_PCI_H
-
-#include "qemu-common.h"
-
-/* vga-pci.c */
-DeviceState *pci_std_vga_init(PCIBus *bus);
-
-/* cirrus_vga.c */
-DeviceState *pci_cirrus_vga_init(PCIBus *bus);
-
-#endif
diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index f5e4f44..5796d89 100644
--- a/hw/vmware_vga.c
+++ b/hw/vmware_vga.c
@@ -25,7 +25,6 @@
#include "loader.h"
#include "console.h"
#include "pci.h"
-#include "vmware_vga.h"
#undef VERBOSE
#define HW_RECT_ACCEL
diff --git a/hw/vmware_vga.h b/hw/vmware_vga.h
deleted file mode 100644
index 000fbdd..0000000
--- a/hw/vmware_vga.h
+++ /dev/null
@@ -1,15 +0,0 @@
-#ifndef QEMU_VMWARE_VGA_H
-#define QEMU_VMWARE_VGA_H
-
-#include "qemu-common.h"
-
-/* vmware_vga.c */
-static inline DeviceState *pci_vmsvga_init(PCIBus *bus)
-{
- PCIDevice *dev;
-
- dev = pci_create_simple(bus, -1, "vmware-svga");
- return &dev->qdev;
-}
-
-#endif
diff --git a/sysemu.h b/sysemu.h
index 65552ac..0587b38 100644
--- a/sysemu.h
+++ b/sysemu.h
@@ -105,11 +105,7 @@ typedef enum {
} VGAInterfaceType;
extern int vga_interface_type;
-#define cirrus_vga_enabled (vga_interface_type == VGA_CIRRUS)
-#define std_vga_enabled (vga_interface_type == VGA_STD)
#define xenfb_enabled (vga_interface_type == VGA_XENFB)
-#define vmsvga_enabled (vga_interface_type == VGA_VMWARE)
-#define qxl_enabled (vga_interface_type == VGA_QXL)
extern int graphic_width;
extern int graphic_height;
--
1.7.10.4
next prev parent reply other threads:[~2012-09-08 11:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-08 11:26 [Qemu-devel] [PATCH 00/12] Rework PCI video card initialization Aurelien Jarno
2012-09-08 11:26 ` [Qemu-devel] [PATCH 01/12] vga: rename pci_vga_init() into pci_std_vga_init() Aurelien Jarno
2012-09-08 12:33 ` Blue Swirl
2012-09-08 12:35 ` Andreas Färber
2012-09-08 11:26 ` [Qemu-devel] [PATCH 02/12] vl.c: check for qxl availability Aurelien Jarno
2012-09-08 12:40 ` Andreas Färber
2012-09-08 11:26 ` [Qemu-devel] [PATCH 03/12] pci: add a pci_vga_init() function Aurelien Jarno
2012-09-08 11:26 ` [Qemu-devel] [PATCH 04/12] mips/malta: use the new " Aurelien Jarno
2012-09-08 11:26 ` [Qemu-devel] [PATCH 05/12] alpha: " Aurelien Jarno
2012-09-08 14:47 ` Alexander Graf
2012-09-08 14:57 ` Aurelien Jarno
2012-09-08 15:00 ` Alexander Graf
2012-09-08 15:04 ` Alexander Graf
2012-09-10 15:56 ` Richard Henderson
2012-09-08 11:26 ` [Qemu-devel] [PATCH 06/12] ppc/newworld: " Aurelien Jarno
2012-09-08 11:26 ` [Qemu-devel] [PATCH 07/12] ppc/oldworld: " Aurelien Jarno
2012-09-08 11:26 ` [Qemu-devel] [PATCH 08/12] ppc/prep: " Aurelien Jarno
2012-09-08 12:50 ` Andreas Färber
2012-09-08 11:26 ` [Qemu-devel] [PATCH 09/12] ppc/pSeries: " Aurelien Jarno
2012-09-08 11:26 ` [Qemu-devel] [PATCH 10/12] sun/sun4u: " Aurelien Jarno
2012-09-08 12:32 ` Blue Swirl
2012-09-08 11:26 ` [Qemu-devel] [PATCH 11/12] pc: " Aurelien Jarno
2012-09-08 12:35 ` Blue Swirl
2012-09-08 11:26 ` Aurelien Jarno [this message]
2012-09-08 14:53 ` [Qemu-devel] [PATCH 00/12] Rework PCI video card initialization Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347103584-20598-13-git-send-email-aurelien@aurel32.net \
--to=aurelien@aurel32.net \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).