From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB4Dz-0003fG-ML for qemu-devel@nongnu.org; Mon, 10 Sep 2012 09:40:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TB4Dr-0002BE-Mt for qemu-devel@nongnu.org; Mon, 10 Sep 2012 09:40:27 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:54547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB4Dr-0002Ah-GE for qemu-devel@nongnu.org; Mon, 10 Sep 2012 09:40:19 -0400 Received: by pbbrp12 with SMTP id rp12so1264650pbb.4 for ; Mon, 10 Sep 2012 06:40:18 -0700 (PDT) Sender: Richard Henderson Message-ID: <1347284409.8336.3.camel@pebble.twiddle.home> From: Richard Henderson Date: Mon, 10 Sep 2012 06:40:09 -0700 In-Reply-To: <1347278184-18693-1-git-send-email-aurelien@aurel32.net> References: <1347278184-18693-1-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tcg/i386: allow constants in load/store ops List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On Mon, 2012-09-10 at 13:56 +0200, Aurelien Jarno wrote: > On x86, it is possible to move a constant value to memory. Add code to > handle a constant argument to load/store ops. > > Signed-off-by: Aurelien Jarno While useful, you'll find that most constants that want storing to memory are not generated with store opcodes, but directly via tcg_out_st. As happens for all register spilling, and helper calls. Reviewed-by: Richard Henderson r~