[Qemu-devel] [PATCH] virtio spec amendment for virtio-ccw

[Qemu-devel] [PATCH] virtio spec amendment for virtio-ccw

[Heinz Graalfs]

Rusty, here is Conny's virtio spec amendment.

Cornelia Huck (1):
  virtio-ccw: Add secondary indicators.

 virtio-spec.lyx | 28 +++++++++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

-- 
1.7.11.5

[Qemu-devel] [PATCH] virtio-ccw: Add secondary indicators.

[Heinz Graalfs]

From: Cornelia Huck <cornelia.huck@de.ibm.com>

Add a ccw to specify the location of indicators for configuration
changes and notice how they are to be used.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 virtio-spec.lyx | 28 +++++++++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

diff --git a/virtio-spec.lyx b/virtio-spec.lyx
index 8247d2e..41318b1 100644
--- a/virtio-spec.lyx
+++ b/virtio-spec.lyx
@@ -9442,13 +9442,20 @@ status open
 
 \begin_layout LyX-Code
 
-\change_inserted -385801441 1343732726
+\change_inserted -385801441 1347015671
 
 #define CCW_CMD_SET_IND 0x43
 \end_layout
 
 \begin_layout LyX-Code
 
+\change_inserted -385801441 1347015690
+
+#define CCW_CMD_SET_CONF_IND 0x53
+\end_layout
+
+\begin_layout LyX-Code
+
 \change_inserted -385801441 1343732726
 
 #define CCW_CMD_READ_FEAT 0x12
@@ -9819,12 +9826,19 @@ Setting Up Indicators
 
 \begin_layout Standard
 
-\change_inserted -385801441 1343732726
+\change_inserted -385801441 1347015710
 To communicate the location of the indicator bits for host->guest notification,
  the guest uses the CCW_CMD_SET_IND command which sends the guest address
  of the indicators in a 64 bit value.
 \end_layout
 
+\begin_layout Standard
+
+\change_inserted -385801441 1347015749
+For the indicator bits used in the configuration change host->guest notification
+, the CCW_CMD_SET_CONF_IND command is used analogously.
+\end_layout
+
 \begin_layout Subsection*
 
 \change_inserted -385801441 1343732726
@@ -9839,13 +9853,21 @@ Host->Guest Notification
 
 \begin_layout Standard
 
-\change_inserted -385801441 1343732726
+\change_inserted -385801441 1347015762
 For notifying the guest of virtqueue buffers, the host sets the corresponding
  bit in the guest-provided indicators.
  If an interrupt is not already pending for the subchannel, the host generates
  an unsolicited I/O interrupt.
 \end_layout
 
+\begin_layout Standard
+
+\change_inserted -385801441 1347015847
+If the host wants to notify the guest about configuration changes, it sets
+ bit 0 in the configuration indicators and generates an unsolicited I/O
+ interrupt, if needed.
+\end_layout
+
 \begin_layout Subsubsection*
 
 \change_inserted -385801441 1343732726
-- 
1.7.11.5

Re: [Qemu-devel] [PATCH] virtio spec amendment for virtio-ccw

[Rusty Russell]

Heinz Graalfs <graalfs@linux.vnet.ibm.com> writes:

> Rusty, here is Conny's virtio spec amendment.
>
> Cornelia Huck (1):
>   virtio-ccw: Add secondary indicators.

Technically, you should have signed this off too.

But applied anyway,
Rusty.