qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Orit Wasserman <owasserm@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, aliguori@us.ibm.com, quintela@redhat.com,
	armbru@redhat.com, mst@redhat.com, mdroth@linux.vnet.ibm.com,
	lcapitulino@redhat.com, Orit Wasserman <owasserm@redhat.com>,
	pbonzini@redhat.com, akong@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/3] nonblocking connect address handling cleanup
Date: Wed, 12 Sep 2012 14:12:55 +0300	[thread overview]
Message-ID: <1347448378-23915-1-git-send-email-owasserm@redhat.com> (raw)

getaddrinfo can give us a list of addresses, but we only try to
connect to the first one. If that fails we never proceed to
the next one.  This is common on desktop setups that often have ipv6
configured but not actually working.
A simple way to reproduce the problem is migration:
for the destination use -incoming tcp:0:4444, run migrate -d tcp:localhost:4444
migration will fail on hosts that have both IPv4 and IPV6 address for localhost.

To fix this, refactor address resolution code and make inet_nonblocking_connect
retry connection with a different address.

Orit Wasserman (3):
  Refactor inet_connect_opts function
  Separate inet_connect into inet_connect (blocking) and
    inet_nonblocking_connect
  Fix address handling in inet_nonblocking_connect

 migration-tcp.c |   29 ++-----
 nbd.c           |    2 +-
 qemu-sockets.c  |  254 +++++++++++++++++++++++++++++++++++++++++--------------
 qemu_socket.h   |    9 ++-
 ui/vnc.c        |    2 +-
 5 files changed, 208 insertions(+), 88 deletions(-)

-- 
1.7.7.6

             reply	other threads:[~2012-09-12 11:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 11:12 Orit Wasserman [this message]
2012-09-12 11:12 ` [Qemu-devel] [PATCH v2 1/3] Refactor inet_connect_opts function Orit Wasserman
2012-09-13 12:35   ` Markus Armbruster
2012-09-13 16:44     ` Orit Wasserman
2012-09-13 16:52     ` Orit Wasserman
2012-09-14  7:37       ` Michael S. Tsirkin
2012-09-13 13:14   ` Markus Armbruster
2012-09-13 16:44     ` Orit Wasserman
2012-09-12 11:12 ` [Qemu-devel] [PATCH v2 2/3] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect Orit Wasserman
2012-09-13 12:44   ` Markus Armbruster
2012-09-13 16:40     ` Orit Wasserman
2012-09-12 11:12 ` [Qemu-devel] [PATCH v2 3/3] Fix address handling in inet_nonblocking_connect Orit Wasserman
2012-09-13 13:22   ` Markus Armbruster
2012-09-13 13:32     ` Michael S. Tsirkin
2012-09-13 14:23       ` Orit Wasserman
2012-09-13 17:27     ` Orit Wasserman
2012-09-12 14:16 ` [Qemu-devel] [PATCH v2 0/3] nonblocking connect address handling cleanup Amos Kong
2012-09-12 20:37 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347448378-23915-1-git-send-email-owasserm@redhat.com \
    --to=owasserm@redhat.com \
    --cc=akong@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).