From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCRU6-0001kr-TM for qemu-devel@nongnu.org; Fri, 14 Sep 2012 04:42:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCRU0-0007W0-I2 for qemu-devel@nongnu.org; Fri, 14 Sep 2012 04:42:46 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:36282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCRU0-0007Vp-Bb for qemu-devel@nongnu.org; Fri, 14 Sep 2012 04:42:40 -0400 Received: by weyz53 with SMTP id z53so2179729wey.4 for ; Fri, 14 Sep 2012 01:42:39 -0700 (PDT) From: Stefan Hajnoczi Date: Fri, 14 Sep 2012 09:42:15 +0100 Message-Id: <1347612146-5407-2-git-send-email-stefanha@gmail.com> In-Reply-To: <1347612146-5407-1-git-send-email-stefanha@gmail.com> References: <1347612146-5407-1-git-send-email-stefanha@gmail.com> Subject: [Qemu-devel] [PATCH 01/12] srp: Don't use QEMU_PACKED for single elements of a structured type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Weil , qemu-devel@nongnu.org, Stefan Hajnoczi From: Stefan Weil QEMU_PACKED results in a MinGW compiler warning when it is used for single structure elements: warning: 'gcc_struct' attribute ignored Using QEMU_PACKED for the whole structure avoids the compiler warning without changing the memory layout. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- hw/srp.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/srp.h b/hw/srp.h index 3009bd5..5e0cad5 100644 --- a/hw/srp.h +++ b/hw/srp.h @@ -177,13 +177,13 @@ struct srp_tsk_mgmt { uint8_t reserved1[6]; uint64_t tag; uint8_t reserved2[4]; - uint64_t lun QEMU_PACKED; + uint64_t lun; uint8_t reserved3[2]; uint8_t tsk_mgmt_func; uint8_t reserved4; uint64_t task_tag; uint8_t reserved5[8]; -}; +} QEMU_PACKED; /* * We need the packed attribute because the SRP spec only aligns the @@ -198,14 +198,14 @@ struct srp_cmd { uint8_t data_in_desc_cnt; uint64_t tag; uint8_t reserved2[4]; - uint64_t lun QEMU_PACKED; + uint64_t lun; uint8_t reserved3; uint8_t task_attr; uint8_t reserved4; uint8_t add_cdb_len; uint8_t cdb[16]; uint8_t add_data[0]; -}; +} QEMU_PACKED; enum { SRP_RSP_FLAG_RSPVALID = 1 << 0, -- 1.7.10.4