From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCVBL-0008FK-9b for qemu-devel@nongnu.org; Fri, 14 Sep 2012 08:39:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCVBF-0004tn-8l for qemu-devel@nongnu.org; Fri, 14 Sep 2012 08:39:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCVBE-0004tK-QD for qemu-devel@nongnu.org; Fri, 14 Sep 2012 08:39:33 -0400 From: Kevin Wolf Date: Fri, 14 Sep 2012 14:39:12 +0200 Message-Id: <1347626352-6023-12-git-send-email-kwolf@redhat.com> In-Reply-To: <1347626352-6023-1-git-send-email-kwolf@redhat.com> References: <1347626352-6023-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 11/11] block: Don't forget to delete temporary file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Dunrong Huang The caller would not delete temporary file after failed get_tmp_filename(). Signed-off-by: Dunrong Huang Signed-off-by: Kevin Wolf --- block.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index c754353..e78039b 100644 --- a/block.c +++ b/block.c @@ -433,7 +433,11 @@ int get_tmp_filename(char *filename, int size) return -EOVERFLOW; } fd = mkstemp(filename); - if (fd < 0 || close(fd)) { + if (fd < 0) { + return -errno; + } + if (close(fd) != 0) { + unlink(filename); return -errno; } return 0; -- 1.7.6.5