From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCVB7-0007fE-Pq for qemu-devel@nongnu.org; Fri, 14 Sep 2012 08:39:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCVB5-0004qZ-3L for qemu-devel@nongnu.org; Fri, 14 Sep 2012 08:39:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCVB4-0004qP-RN for qemu-devel@nongnu.org; Fri, 14 Sep 2012 08:39:23 -0400 From: Kevin Wolf Date: Fri, 14 Sep 2012 14:39:05 +0200 Message-Id: <1347626352-6023-5-git-send-email-kwolf@redhat.com> In-Reply-To: <1347626352-6023-1-git-send-email-kwolf@redhat.com> References: <1347626352-6023-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 04/11] block/curl: Fix wrong free statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Stefan Weil Report from smatch: block/curl.c:546 curl_close(21) info: redundant null check on s->url calling free() The check was redundant, and free was also wrong because the memory was allocated using g_strdup. Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf --- block/curl.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/block/curl.c b/block/curl.c index e7c3634..c1074cd 100644 --- a/block/curl.c +++ b/block/curl.c @@ -542,8 +542,7 @@ static void curl_close(BlockDriverState *bs) } if (s->multi) curl_multi_cleanup(s->multi); - if (s->url) - free(s->url); + g_free(s->url); } static int64_t curl_getlength(BlockDriverState *bs) -- 1.7.6.5