From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDXJp-0005Vr-5d for qemu-devel@nongnu.org; Mon, 17 Sep 2012 05:08:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDXJo-0003YT-7f for qemu-devel@nongnu.org; Mon, 17 Sep 2012 05:08:41 -0400 From: Laszlo Ersek Date: Mon, 17 Sep 2012 11:10:03 +0200 Message-Id: <1347873003-11593-1-git-send-email-lersek@redhat.com> Subject: [Qemu-devel] [PATCH] TextConsole: saturate escape parameter in TTY_STATE_CSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, armbru@redhat.com, lersek@redhat.com Signed-off-by: Laszlo Ersek --- Build tested. console.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/console.c b/console.c index c1ed5e0..67080f4 100644 --- a/console.c +++ b/console.c @@ -938,8 +938,11 @@ static void console_putchar(TextConsole *s, int ch) case TTY_STATE_CSI: /* handle escape sequence parameters */ if (ch >= '0' && ch <= '9') { if (s->nb_esc_params < MAX_ESC_PARAMS) { - s->esc_params[s->nb_esc_params] = - s->esc_params[s->nb_esc_params] * 10 + ch - '0'; + int *param = &s->esc_params[s->nb_esc_params]; + int digit = (ch - '0'); + + *param = (*param <= (INT_MAX - digit) / 10) ? + *param * 10 + digit : INT_MAX; } } else { if (s->nb_esc_params < MAX_ESC_PARAMS) -- 1.7.1