From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [RFC PATCH 03/10] vl: implement tcg_enabled() and tcg_available() as for other accelerators
Date: Mon, 17 Sep 2012 18:00:42 +0200 [thread overview]
Message-ID: <1347897649-23236-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1347897649-23236-1-git-send-email-pbonzini@redhat.com>
From: Anthony Liguori <aliguori@us.ibm.com>
This way, tcg_enabled() can be used to stub out entire sections of code
that are not used on TCG. This will limit the use of #ifdef and improves
code checking from the compiler.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
arch_init.c | 4 ++++
exec.c | 6 +-----
qemu-common.h | 8 +++++++-
vl.c | 2 +-
4 file modificati, 13 inserzioni(+), 7 rimozioni(-)
diff --git a/arch_init.c b/arch_init.c
index 5a1173e..fb41467 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -1061,7 +1061,11 @@ int audio_available(void)
int tcg_available(void)
{
+#if defined(CONFIG_TCG)
return 1;
+#else
+ return 0;
+#endif
}
int kvm_available(void)
diff --git a/exec.c b/exec.c
index 5834766..1270d78 100644
--- a/exec.c
+++ b/exec.c
@@ -615,6 +615,7 @@ static void code_gen_alloc(unsigned long tb_size)
size. */
void tcg_exec_init(unsigned long tb_size)
{
+ tcg_allowed = 1;
cpu_gen_init();
code_gen_alloc(tb_size);
code_gen_ptr = code_gen_buffer;
@@ -627,11 +628,6 @@ void tcg_exec_init(unsigned long tb_size)
#endif
}
-bool tcg_enabled(void)
-{
- return code_gen_buffer != NULL;
-}
-
void cpu_exec_init_all(void)
{
#if !defined(CONFIG_USER_ONLY)
diff --git a/qemu-common.h b/qemu-common.h
index e5c2bcd..6a3b075 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -301,8 +301,14 @@ typedef struct PCIHostDeviceAddress {
unsigned int function;
} PCIHostDeviceAddress;
+extern int tcg_allowed;
void tcg_exec_init(unsigned long tb_size);
-bool tcg_enabled(void);
+
+#ifdef CONFIG_TCG
+#define tcg_enabled() (tcg_allowed)
+#else
+#define tcg_enabled() 0
+#endif
void cpu_exec_init_all(void);
diff --git a/vl.c b/vl.c
index 7c577fa..fa022d1 100644
--- a/vl.c
+++ b/vl.c
@@ -260,7 +260,7 @@ static NotifierList exit_notifiers =
static NotifierList machine_init_done_notifiers =
NOTIFIER_LIST_INITIALIZER(machine_init_done_notifiers);
-static int tcg_allowed = 1;
+int tcg_allowed = 0;
int kvm_allowed = 0;
int xen_allowed = 0;
uint32_t xen_domid;
--
1.7.12
next prev parent reply other threads:[~2012-09-17 16:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 16:00 [Qemu-devel] [RFC PATCH 00/10] Add --disable-tcg Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 01/10] configure: factor out list of supported Xen/KVM targets Paolo Bonzini
2012-09-17 17:02 ` Peter Maydell
2012-09-17 17:09 ` Paolo Bonzini
2012-09-17 17:13 ` Peter Maydell
2012-09-17 18:21 ` Stefano Stabellini
2012-09-17 18:30 ` Stefano Stabellini
2012-09-17 18:53 ` Stefano Stabellini
2012-09-17 19:15 ` Peter Maydell
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 02/10] configure: add CONFIG_TCG=y to config-host.mak Paolo Bonzini
2012-09-17 16:00 ` Paolo Bonzini [this message]
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void Paolo Bonzini
2012-09-17 17:06 ` Peter Maydell
2012-09-17 17:09 ` Paolo Bonzini
2012-09-17 17:20 ` Peter Maydell
2012-09-17 18:25 ` Paolo Bonzini
2012-09-17 18:57 ` Peter Maydell
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 05/10] exec: small adjustments for TCG separation Paolo Bonzini
2012-09-17 19:17 ` Blue Swirl
2012-09-17 21:47 ` Richard Henderson
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 06/10] monitor: disable info jit if !TCG Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 07/10] configure: emit summary at the very end Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 08/10] configure: add --disable-tcg configure option Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 09/10] i386: move TCG functions out of helper.o, non-TCG functions to cpu.o Paolo Bonzini
2012-09-17 17:12 ` Peter Maydell
2012-09-17 18:39 ` Paolo Bonzini
2012-09-17 19:15 ` Blue Swirl
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 10/10] build: do not build TCG files if TCG is disabled Paolo Bonzini
2012-09-17 19:20 ` [Qemu-devel] [RFC PATCH 00/10] Add --disable-tcg Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347897649-23236-4-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).