From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void
Date: Mon, 17 Sep 2012 18:00:43 +0200 [thread overview]
Message-ID: <1347897649-23236-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1347897649-23236-1-git-send-email-pbonzini@redhat.com>
The return value is used nowhere.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
exec-all.h | 4 ++--
translate-all.c | 9 ++++-----
2 file modificati, 6 inserzioni(+), 7 rimozioni(-)
diff --git a/exec-all.h b/exec-all.h
index dba9609..cecafa1 100644
--- a/exec-all.h
+++ b/exec-all.h
@@ -84,8 +84,8 @@ void restore_state_to_opc(CPUArchState *env, struct TranslationBlock *tb,
void cpu_gen_init(void);
int cpu_gen_code(CPUArchState *env, struct TranslationBlock *tb,
int *gen_code_size_ptr);
-int cpu_restore_state(struct TranslationBlock *tb,
- CPUArchState *env, uintptr_t searched_pc);
+void cpu_restore_state(struct TranslationBlock *tb,
+ CPUArchState *env, uintptr_t searched_pc);
void QEMU_NORETURN cpu_resume_from_signal(CPUArchState *env1, void *puc);
void QEMU_NORETURN cpu_io_recompile(CPUArchState *env, uintptr_t retaddr);
TranslationBlock *tb_gen_code(CPUArchState *env,
diff --git a/translate-all.c b/translate-all.c
index 5bd2d37..f2f9036 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -108,8 +108,8 @@ int cpu_gen_code(CPUArchState *env, TranslationBlock *tb, int *gen_code_size_ptr
/* The cpu state corresponding to 'searched_pc' is restored.
*/
-int cpu_restore_state(TranslationBlock *tb,
- CPUArchState *env, uintptr_t searched_pc)
+void cpu_restore_state(TranslationBlock *tb,
+ CPUArchState *env, uintptr_t searched_pc)
{
TCGContext *s = &tcg_ctx;
int j;
@@ -135,7 +135,7 @@ int cpu_restore_state(TranslationBlock *tb,
/* find opc index corresponding to search_pc */
tc_ptr = (uintptr_t)tb->tc_ptr;
if (searched_pc < tc_ptr)
- return -1;
+ return;
s->tb_next_offset = tb->tb_next_offset;
#ifdef USE_DIRECT_JUMP
@@ -147,7 +147,7 @@ int cpu_restore_state(TranslationBlock *tb,
#endif
j = tcg_gen_code_search_pc(s, (uint8_t *)tc_ptr, searched_pc - tc_ptr);
if (j < 0)
- return -1;
+ return;
/* now find start of instruction before */
while (gen_opc_instr_start[j] == 0)
j--;
@@ -159,5 +159,4 @@ int cpu_restore_state(TranslationBlock *tb,
s->restore_time += profile_getclock() - ti;
s->restore_count++;
#endif
- return 0;
}
--
1.7.12
next prev parent reply other threads:[~2012-09-17 16:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 16:00 [Qemu-devel] [RFC PATCH 00/10] Add --disable-tcg Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 01/10] configure: factor out list of supported Xen/KVM targets Paolo Bonzini
2012-09-17 17:02 ` Peter Maydell
2012-09-17 17:09 ` Paolo Bonzini
2012-09-17 17:13 ` Peter Maydell
2012-09-17 18:21 ` Stefano Stabellini
2012-09-17 18:30 ` Stefano Stabellini
2012-09-17 18:53 ` Stefano Stabellini
2012-09-17 19:15 ` Peter Maydell
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 02/10] configure: add CONFIG_TCG=y to config-host.mak Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 03/10] vl: implement tcg_enabled() and tcg_available() as for other accelerators Paolo Bonzini
2012-09-17 16:00 ` Paolo Bonzini [this message]
2012-09-17 17:06 ` [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void Peter Maydell
2012-09-17 17:09 ` Paolo Bonzini
2012-09-17 17:20 ` Peter Maydell
2012-09-17 18:25 ` Paolo Bonzini
2012-09-17 18:57 ` Peter Maydell
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 05/10] exec: small adjustments for TCG separation Paolo Bonzini
2012-09-17 19:17 ` Blue Swirl
2012-09-17 21:47 ` Richard Henderson
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 06/10] monitor: disable info jit if !TCG Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 07/10] configure: emit summary at the very end Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 08/10] configure: add --disable-tcg configure option Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 09/10] i386: move TCG functions out of helper.o, non-TCG functions to cpu.o Paolo Bonzini
2012-09-17 17:12 ` Peter Maydell
2012-09-17 18:39 ` Paolo Bonzini
2012-09-17 19:15 ` Blue Swirl
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 10/10] build: do not build TCG files if TCG is disabled Paolo Bonzini
2012-09-17 19:20 ` [Qemu-devel] [RFC PATCH 00/10] Add --disable-tcg Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347897649-23236-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).