From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE3zD-0006fO-11 for qemu-devel@nongnu.org; Tue, 18 Sep 2012 16:01:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TE3z8-0004B0-RP for qemu-devel@nongnu.org; Tue, 18 Sep 2012 16:01:34 -0400 Received: from vms173011pub.verizon.net ([206.46.173.11]:52337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE3z8-0004Ai-AO for qemu-devel@nongnu.org; Tue, 18 Sep 2012 16:01:30 -0400 Received: from wf-rch.minyard.home ([unknown] [173.57.151.210]) by vms173011.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0MAK00KWSA9O8KC2@vms173011.mailsrvcs.net> for qemu-devel@nongnu.org; Tue, 18 Sep 2012 15:01:07 -0500 (CDT) From: minyard@acm.org Date: Tue, 18 Sep 2012 15:00:34 -0500 Message-id: <1347998443-20599-8-git-send-email-minyard@acm.org> In-reply-to: <1347998443-20599-1-git-send-email-minyard@acm.org> References: <1347998443-20599-1-git-send-email-minyard@acm.org> Subject: [Qemu-devel] [PATCH 07/16] qom: release previous object when setting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Corey Minyard From: Corey Minyard When setting an object, if you don't release the previous object that was there, it may become unusable. This change allows a chardev to be removed from one object's properties and added to another's. Signed-off-by: Corey Minyard Acked-by: Paolo Bonzini --- qom/object.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qom/object.c b/qom/object.c index e3e9242..6bbb6a8 100644 --- a/qom/object.c +++ b/qom/object.c @@ -692,6 +692,9 @@ void object_property_set(Object *obj, Visitor *v, const char *name, if (!prop->set) { error_set(errp, QERR_PERMISSION_DENIED); } else { + if (prop->release) { + prop->release(obj, name, prop->opaque); + } prop->set(obj, v, prop->opaque, name, errp); } } -- 1.7.4.1