From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 00/12] QAPI prerequisites for the embedded NBD server
Date: Wed, 19 Sep 2012 16:31:03 +0200 [thread overview]
Message-ID: <1348065078-5139-1-git-send-email-pbonzini@redhat.com> (raw)
Dan's request for file descriptor passing in the embedded NBD server opened
a nice can of worms. :)
This is because there is no existing QAPI description of socket addresses
and similar things, plus QAPI-fication of qemu-sockets.c is a bit sparse.
This series tries to fix this. It includes three extra patches at the
end that actually implement the NBD server and serve as an example of
the new socket creation APIs. I would ask for your review of patches
14 and 15 anyway, so I don't mind if you take these three as well; I
terminated the series officially at patch 12 just because these three
require the changes from my outstanding NBD pull request.
Patches 1 and 2 add error propagation to named file descriptors. These
should go in as a prerequisite to the QAPI conversion of add_client.
Patches 3 and 4 are small fixes to the QAPI scripts. Nothing spectacular.
Patches 5 to 10 start moving qemu-sockets functions away from error_report
(or printf) and away from QemuOpts. And after patch 11 harmonizes a
bit the Unix-socket functions, patch 12 introduces the new socket API.
Please review!
Paolo Bonzini (12):
monitor: use monitor_handle_fd_param for non-Error-friendly users of named fds
monitor: add Error * argument to monitor_get_fd
qapi: do not protect enum values from namespace pollution
qapi: add "unix" to the set of reserved words
build: add QAPI files to the tools
qapi: add socket address types
qemu-sockets: add error propagation to inet_parse
qemu-sockets: add error propagation to Unix socket functions
qemu-sockets: return IPSocketAddress from inet_parse
qemu-sockets: move block from QemuOpts to arguments
qemu-sockets: add block and in_progress arguments to unix_connect_opts
qemu-sockets: add socket_listen, socket_connect, socket_parse
Makefile.objs | 3 +-
dump.c | 5 +-
hw/kvm/pci-assign.c | 4 +-
migration-fd.c | 3 +-
monitor.c | 15 +--
monitor.h | 2 +-
nbd.c | 4 +-
qapi-schema.json | 53 +++++++++
qemu-char.c | 6 +-
qemu-sockets.c | 289 ++++++++++++++++++++++++++++++++++++++------------
qemu-tool.c | 6 ++
qemu_socket.h | 14 ++-
qga/channel-posix.c | 2 +-
scripts/qapi-types.py | 4 +-
scripts/qapi-visit.py | 2 +-
scripts/qapi.py | 10 +-
ui/vnc.c | 4 +-
17 file modificati, 321 inserzioni(+), 105 rimozioni(-)
--
1.7.12
next reply other threads:[~2012-09-19 14:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 14:31 Paolo Bonzini [this message]
2012-09-19 14:31 ` [Qemu-devel] [PATCH 01/12] monitor: use monitor_handle_fd_param for non-Error-friendly users of named fds Paolo Bonzini
2012-09-19 20:42 ` Luiz Capitulino
2012-09-20 8:09 ` Paolo Bonzini
2012-09-20 13:47 ` Luiz Capitulino
2012-09-20 14:33 ` Paolo Bonzini
2012-09-19 14:31 ` [Qemu-devel] [PATCH 02/12] monitor: add Error * argument to monitor_get_fd Paolo Bonzini
2012-09-19 20:47 ` Luiz Capitulino
2012-09-19 14:31 ` [Qemu-devel] [PATCH 03/12] qapi: do not protect enum values from namespace pollution Paolo Bonzini
2012-09-20 14:07 ` Luiz Capitulino
2012-09-19 14:31 ` [Qemu-devel] [PATCH 04/12] qapi: add "unix" to the set of reserved words Paolo Bonzini
2012-09-19 15:46 ` Peter Maydell
2012-09-19 15:58 ` Paolo Bonzini
2012-09-19 16:02 ` Paolo Bonzini
2012-09-19 19:29 ` Blue Swirl
2012-09-20 14:08 ` Luiz Capitulino
2012-09-19 14:31 ` [Qemu-devel] [PATCH 05/12] build: add QAPI files to the tools Paolo Bonzini
2012-09-19 14:31 ` [Qemu-devel] [PATCH 06/12] qapi: add socket address types Paolo Bonzini
2012-09-19 17:20 ` Eric Blake
2012-09-20 8:01 ` Paolo Bonzini
2012-09-19 14:31 ` [Qemu-devel] [PATCH 07/12] qemu-sockets: add error propagation to inet_parse Paolo Bonzini
2012-09-19 14:31 ` [Qemu-devel] [PATCH 08/12] qemu-sockets: add error propagation to Unix socket functions Paolo Bonzini
2012-09-19 14:31 ` [Qemu-devel] [PATCH 09/12] qemu-sockets: return IPSocketAddress from inet_parse Paolo Bonzini
2012-09-19 14:31 ` [Qemu-devel] [PATCH 10/12] qemu-sockets: move block from QemuOpts to arguments Paolo Bonzini
2012-09-19 14:31 ` [Qemu-devel] [PATCH 11/12] qemu-sockets: add block and in_progress arguments to unix_connect_opts Paolo Bonzini
2012-09-19 14:31 ` [Qemu-devel] [PATCH 12/12] qemu-sockets: add socket_listen, socket_connect, socket_parse Paolo Bonzini
2012-09-19 14:31 ` [Qemu-devel] [PATCH 13/12] block: add close notifiers Paolo Bonzini
2012-09-19 14:31 ` [Qemu-devel] [PATCH 14/12] qmp: add NBD server commands Paolo Bonzini
2012-09-19 17:48 ` Eric Blake
2012-09-20 8:01 ` Paolo Bonzini
2012-09-19 14:31 ` [Qemu-devel] [PATCH 15/12] hmp: " Paolo Bonzini
2012-09-19 18:02 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348065078-5139-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).