From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEei3-0000Bs-51 for qemu-devel@nongnu.org; Thu, 20 Sep 2012 07:14:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEehb-00088Y-Ii for qemu-devel@nongnu.org; Thu, 20 Sep 2012 07:14:19 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:50003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEehb-00087i-9S for qemu-devel@nongnu.org; Thu, 20 Sep 2012 07:13:51 -0400 From: Anthony PERARD Date: Thu, 20 Sep 2012 12:12:54 +0100 Message-ID: <1348139574-23324-6-git-send-email-anthony.perard@citrix.com> In-Reply-To: <1348139574-23324-1-git-send-email-anthony.perard@citrix.com> References: <1348139574-23324-1-git-send-email-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH V3 5/5] xen: Set the vram dirty when an error occur. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU-devel Cc: Anthony Liguori , Luiz Capitulino , Stefano Stabellini , Avi Kivity , Anthony PERARD , Xen Devel If the call to xc_hvm_track_dirty_vram() fails, then we set dirtybit on all the video ram. This case happens during migration, but we don't need a special case for live migration with patch. Signed-off-by: Anthony PERARD --- xen-all.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen-all.c b/xen-all.c index 6250593..ab28261 100644 --- a/xen-all.c +++ b/xen-all.c @@ -507,7 +507,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state, bitmap); if (rc < 0) { if (rc != -ENODATA) { - fprintf(stderr, "xen: track_dirty_vram failed (0x" TARGET_FMT_plx + memory_region_set_dirty(framebuffer, 0, size); + DPRINTF("xen: track_dirty_vram failed (0x" TARGET_FMT_plx ", 0x" TARGET_FMT_plx "): %s\n", start_addr, start_addr + size, strerror(-rc)); } -- Anthony PERARD