qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Don Slutz <Don@CloudSwitch.com>
To: qemu-devel@nongnu.org, ehabkost@redhat.com, imammedo@redhat.com,
	kvm@vger.kernel.org
Cc: Don Slutz <Don@CloudSwitch.com>
Subject: [Qemu-devel] [PATCH v2 1/1] target-i386: Fix default Hypervisor level for hypervisor-vendor=kvm.
Date: Thu, 20 Sep 2012 16:06:27 -0400	[thread overview]
Message-ID: <1348171587-23725-2-git-send-email-Don@CloudSwitch.com> (raw)
In-Reply-To: <1348171587-23725-1-git-send-email-Don@CloudSwitch.com>

>From http://lkml.indiana.edu/hypermail/linux/kernel/1205.0/00100.html
EAX should be KVM_CPUID_FEATURES (0x40000001) not 0.

Added hypervisor-vendor=kvm0 to get the older CPUID result. kvm1 selects the newer one.

Signed-off-by: Don Slutz <Don@CloudSwitch.com>
---
 target-i386/cpu.c |   17 +++++++++++++----
 1 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 72a8442..e51b2b1 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1250,9 +1250,12 @@ static char *x86_cpuid_get_hv_vendor(Object *obj, Error **errp)
     } else if (!strcmp(value, CPUID_HV_VENDOR_XEN) &&
                env->cpuid_hv_level == CPUID_HV_LEVEL_XEN) {
         pstrcpy(value, sizeof(value), "xen");
-    } else if (!strcmp(value, CPUID_HV_VENDOR_KVM) &&
-               env->cpuid_hv_level == 0) {
-        pstrcpy(value, sizeof(value), "kvm");
+    } else if (!strcmp(value, CPUID_HV_VENDOR_KVM)) {
+        if (env->cpuid_hv_level == CPUID_HV_LEVEL_KVM) {
+            pstrcpy(value, sizeof(value), "kvm1");
+        } else if (env->cpuid_hv_level == 0) {
+            pstrcpy(value, sizeof(value), "kvm0");
+        }
     }
     return value;
 }
@@ -1288,7 +1291,13 @@ static void x86_cpuid_set_hv_vendor(Object *obj, const char *value,
             env->cpuid_hv_level = CPUID_HV_LEVEL_XEN;
         }
         pstrcpy(adj_value, sizeof(adj_value), CPUID_HV_VENDOR_XEN);
-    } else if (!strcmp(value, "kvm")) {
+    } else if (!strcmp(value, "kvm") || !strcmp(value, "kvm1")) {
+        if (env->cpuid_hv_level == 0) {
+            env->cpuid_hv_level = CPUID_HV_LEVEL_KVM;
+        }
+        pstrcpy(adj_value, sizeof(adj_value), CPUID_HV_VENDOR_KVM);
+    } else if (!strcmp(value, "kvm0")) {
+        env->cpuid_hv_level = 0;
         pstrcpy(adj_value, sizeof(adj_value), CPUID_HV_VENDOR_KVM);
     } else {
         pstrcpy(adj_value, sizeof(adj_value), value);
-- 
1.7.1

  reply	other threads:[~2012-09-20 20:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20 20:06 [Qemu-devel] [PATCH v2 0/1] target-i386: Fix default Hypervisor level for kvm Don Slutz
2012-09-20 20:06 ` Don Slutz [this message]
2012-09-21 14:18   ` [Qemu-devel] [PATCH v2 1/1] target-i386: Fix default Hypervisor level for hypervisor-vendor=kvm Eduardo Habkost
2012-09-21 20:26     ` Don Slutz
2012-09-21 20:49       ` Eduardo Habkost
2012-09-21 21:28         ` Don Slutz
2012-09-21 21:53           ` Eduardo Habkost
2012-09-22  3:26             ` Don Slutz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348171587-23725-2-git-send-email-Don@CloudSwitch.com \
    --to=don@cloudswitch.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).