From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF98n-0008BP-1O for qemu-devel@nongnu.org; Fri, 21 Sep 2012 15:43:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF98h-0002lN-33 for qemu-devel@nongnu.org; Fri, 21 Sep 2012 15:43:56 -0400 Received: from hall.aurel32.net ([88.191.126.93]:43257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF98g-0002k2-PC for qemu-devel@nongnu.org; Fri, 21 Sep 2012 15:43:50 -0400 From: Aurelien Jarno Date: Fri, 21 Sep 2012 21:43:12 +0200 Message-Id: <1348256598-8146-5-git-send-email-aurelien@aurel32.net> In-Reply-To: <1348256598-8146-1-git-send-email-aurelien@aurel32.net> References: <1348256598-8146-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH v2 04/10] tcg/optimize: do copy propagation for all operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Aurelien Jarno It is possible to due copy propagation for all operations, even the one that have side effects or clobber arguments (it only concerns input arguments). That said, the call operation should be handled differently due to the variable number of arguments. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 1904b39..aeb2225 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -378,8 +378,15 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, op = gen_opc_buf[op_index]; def = &tcg_op_defs[op]; /* Do copy propagation */ - if (!(def->flags & (TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS))) { - assert(op != INDEX_op_call); + if (op == INDEX_op_call) { + int nb_oargs = args[0] >> 16; + int nb_iargs = args[0] & 0xffff; + for (i = nb_oargs + 1; i < nb_oargs + nb_iargs + 1; i++) { + if (temps[args[i]].state == TCG_TEMP_COPY) { + args[i] = find_better_copy(s, args[i]); + } + } + } else { for (i = def->nb_oargs; i < def->nb_oargs + def->nb_iargs; i++) { if (temps[args[i]].state == TCG_TEMP_COPY) { args[i] = find_better_copy(s, args[i]); -- 1.7.10.4