From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFF5r-0005CB-OM for qemu-devel@nongnu.org; Fri, 21 Sep 2012 22:05:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFF5q-0000h1-B6 for qemu-devel@nongnu.org; Fri, 21 Sep 2012 22:05:19 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:64906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFF5q-0000d7-4e for qemu-devel@nongnu.org; Fri, 21 Sep 2012 22:05:18 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp12so8850169pbb.4 for ; Fri, 21 Sep 2012 19:05:17 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Fri, 21 Sep 2012 19:04:57 -0700 Message-Id: <1348279507-3617-5-git-send-email-rth@twiddle.net> In-Reply-To: <1348279507-3617-1-git-send-email-rth@twiddle.net> References: <1348279507-3617-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH 04/14] tcg-sparc: Don't MAP_FIXED on top of the program List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl The address we pick in sparc64.ld is also 0x60000000, so doing a fixed map on top of that is guaranteed to blow up. Choosing 0x40000000 is exactly right for the max of code_gen_buffer_size set below. No need to ever use MAP_FIXED. While getting our desired address helps optimize the generated code, we won't fail if we don't get it. Signed-off-by: Richard Henderson --- exec.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index f22e9e6..4510985 100644 --- a/exec.c +++ b/exec.c @@ -543,8 +543,7 @@ static void code_gen_alloc(unsigned long tb_size) code_gen_buffer_size = (800 * 1024 * 1024); #elif defined(__sparc_v9__) // Map the buffer below 2G, so we can use direct calls and branches - flags |= MAP_FIXED; - start = (void *) 0x60000000UL; + start = (void *) 0x40000000UL; if (code_gen_buffer_size > (512 * 1024 * 1024)) code_gen_buffer_size = (512 * 1024 * 1024); #elif defined(__arm__) @@ -584,8 +583,7 @@ static void code_gen_alloc(unsigned long tb_size) code_gen_buffer_size = (800 * 1024 * 1024); #elif defined(__sparc_v9__) // Map the buffer below 2G, so we can use direct calls and branches - flags |= MAP_FIXED; - addr = (void *) 0x60000000UL; + addr = (void *) 0x40000000UL; if (code_gen_buffer_size > (512 * 1024 * 1024)) { code_gen_buffer_size = (512 * 1024 * 1024); } -- 1.7.11.4