From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFizS-0004Aj-Cb for qemu-devel@nongnu.org; Sun, 23 Sep 2012 06:00:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFizQ-0007dp-RV for qemu-devel@nongnu.org; Sun, 23 Sep 2012 06:00:42 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:56983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFizQ-0007dj-EG for qemu-devel@nongnu.org; Sun, 23 Sep 2012 06:00:40 -0400 Received: by wibhq12 with SMTP id hq12so116677wib.10 for ; Sun, 23 Sep 2012 03:00:39 -0700 (PDT) From: Stefan Hajnoczi Date: Sun, 23 Sep 2012 11:00:13 +0100 Message-Id: <1348394420-28298-8-git-send-email-stefanha@gmail.com> In-Reply-To: <1348394420-28298-1-git-send-email-stefanha@gmail.com> References: <1348394420-28298-1-git-send-email-stefanha@gmail.com> Subject: [Qemu-devel] [PATCH 07/14] pflash_cfi01: Fix warning caused by unreachable code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Weil , qemu-devel@nongnu.org, Stefan Hajnoczi From: Stefan Weil Report from smatch: hw/pflash_cfi01.c:431 pflash_write(180) info: ignoring unreachable code. Instead of removing the return statement after the switch statement, the patch replaces the return statements in the switch statement by break statements. Other switch statements in the same code do it also like that. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- hw/pflash_cfi01.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c index 9c42d31..855890d 100644 --- a/hw/pflash_cfi01.c +++ b/hw/pflash_cfi01.c @@ -321,7 +321,7 @@ static void pflash_write(pflash_t *pfl, target_phys_addr_t offset, } pfl->wcycle++; pfl->cmd = cmd; - return; + break; case 1: switch (pfl->cmd) { case 0x10: /* Single Byte Program */ @@ -376,7 +376,7 @@ static void pflash_write(pflash_t *pfl, target_phys_addr_t offset, default: goto error_flash; } - return; + break; case 2: switch (pfl->cmd) { case 0xe8: /* Block write */ @@ -407,7 +407,7 @@ static void pflash_write(pflash_t *pfl, target_phys_addr_t offset, default: goto error_flash; } - return; + break; case 3: /* Confirm mode */ switch (pfl->cmd) { case 0xe8: /* Block write */ @@ -423,7 +423,7 @@ static void pflash_write(pflash_t *pfl, target_phys_addr_t offset, default: goto error_flash; } - return; + break; default: /* Should never happen */ DPRINTF("%s: invalid write state\n", __func__); -- 1.7.10.4