From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 15/19] block: vmdk image file reopen
Date: Mon, 24 Sep 2012 16:26:44 +0200 [thread overview]
Message-ID: <1348496808-8159-16-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1348496808-8159-1-git-send-email-kwolf@redhat.com>
From: Jeff Cody <jcody@redhat.com>
This patch supports reopen for VMDK image files. VMDK extents are added
to the existing reopen queue, so that the transactional model of reopen
is maintained with multiple image files.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/vmdk.c | 35 +++++++++++++++++++++++++++++++++++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index bba4c61..f2e861b 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -300,6 +300,40 @@ static int vmdk_is_cid_valid(BlockDriverState *bs)
return 1;
}
+/* Queue extents, if any, for reopen() */
+static int vmdk_reopen_prepare(BDRVReopenState *state,
+ BlockReopenQueue *queue, Error **errp)
+{
+ BDRVVmdkState *s;
+ int ret = -1;
+ int i;
+ VmdkExtent *e;
+
+ assert(state != NULL);
+ assert(state->bs != NULL);
+
+ if (queue == NULL) {
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR,
+ "No reopen queue for VMDK extents");
+ goto exit;
+ }
+
+ s = state->bs->opaque;
+
+ assert(s != NULL);
+
+ for (i = 0; i < s->num_extents; i++) {
+ e = &s->extents[i];
+ if (e->file != state->bs->file) {
+ bdrv_reopen_queue(queue, e->file, state->flags);
+ }
+ }
+ ret = 0;
+
+exit:
+ return ret;
+}
+
static int vmdk_parent_open(BlockDriverState *bs)
{
char *p_name;
@@ -1646,6 +1680,7 @@ static BlockDriver bdrv_vmdk = {
.instance_size = sizeof(BDRVVmdkState),
.bdrv_probe = vmdk_probe,
.bdrv_open = vmdk_open,
+ .bdrv_reopen_prepare = vmdk_reopen_prepare,
.bdrv_read = vmdk_co_read,
.bdrv_write = vmdk_co_write,
.bdrv_close = vmdk_close,
--
1.7.6.5
next prev parent reply other threads:[~2012-09-24 14:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 14:26 [Qemu-devel] [PULL 00/19] Block patches Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 01/19] blockdev: preserve readonly and snapshot states across media changes Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 02/19] block: correctly set the keep_read_only flag Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 03/19] block: make bdrv_set_enable_write_cache() modify open_flags Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 04/19] block: Framework for reopening files safely Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 05/19] block: move aio initialization into a helper function Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 06/19] block: move open flag parsing in raw block drivers to helper functions Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 07/19] block: do not parse BDRV_O_CACHE_WB in block drivers Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 08/19] block: use BDRV_O_NOCACHE instead of s->aligned_buf in raw-posix.c Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 09/19] block: purge s->aligned_buf and s->aligned_buf_size from raw-posix.c Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 10/19] block: raw-posix image file reopen Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 11/19] block: raw " Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 12/19] block: qed " Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 13/19] block: qcow2 " Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 14/19] block: qcow " Kevin Wolf
2012-09-24 14:26 ` Kevin Wolf [this message]
2012-09-24 14:26 ` [Qemu-devel] [PATCH 16/19] block: vdi " Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 17/19] block: vpc " Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 18/19] block: convert bdrv_commit() to use bdrv_reopen() Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 19/19] block: remove keep_read_only flag from BlockDriverState struct Kevin Wolf
2012-09-25 23:26 ` [Qemu-devel] [PULL 00/19] Block patches Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348496808-8159-16-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).