From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGE1Y-0005tY-JX for qemu-devel@nongnu.org; Mon, 24 Sep 2012 15:08:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGE1X-0003sG-2H for qemu-devel@nongnu.org; Mon, 24 Sep 2012 15:08:56 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:38108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGE1W-0003rr-SV for qemu-devel@nongnu.org; Mon, 24 Sep 2012 15:08:54 -0400 From: Stefan Weil Date: Mon, 24 Sep 2012 21:08:49 +0200 Message-Id: <1348513730-7485-3-git-send-email-sw@weilnetz.de> In-Reply-To: <1348513730-7485-1-git-send-email-sw@weilnetz.de> References: <1348513730-7485-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH 2/3] hw/arm_timer: Fix memory leak (detected by Valgrind) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Weil qi was allocated using g_malloc and never released. It is not necessary to use dynamic memory allocation for qi because it is copied to entries in s->timer and not used otherwise. Signed-off-by: Stefan Weil --- hw/arm_timer.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/arm_timer.c b/hw/arm_timer.c index e3ecce2..9e5f892 100644 --- a/hw/arm_timer.c +++ b/hw/arm_timer.c @@ -269,9 +269,8 @@ static const VMStateDescription vmstate_sp804 = { static int sp804_init(SysBusDevice *dev) { sp804_state *s = FROM_SYSBUS(sp804_state, dev); - qemu_irq *qi; - - qi = qemu_allocate_irqs(sp804_set_irq, s, 2); + qemu_irq qi[2]; + qemu_init_irqs(sp804_set_irq, s, qi, ARRAY_SIZE(qi)); sysbus_init_irq(dev, &s->irq); s->timer[0] = arm_timer_init(s->freq0); s->timer[1] = arm_timer_init(s->freq1); -- 1.7.10