* [Qemu-devel] [PATCH] block-migration: Flush requests in blk_mig_cleanup
@ 2012-09-25 13:53 Kevin Wolf
0 siblings, 0 replies; only message in thread
From: Kevin Wolf @ 2012-09-25 13:53 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, pl, qemu-stable
When cancelling block migration, all in-flight requests of the block
migration must be completed before the data can be freed. This was
visible as failing assertions and segfaults.
Reported-by: Peter Lieven <pl@dlhnet.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block-migration.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/block-migration.c b/block-migration.c
index 7def8ab..ed93301 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -519,6 +519,8 @@ static void blk_mig_cleanup(void)
BlkMigDevState *bmds;
BlkMigBlock *blk;
+ bdrv_drain_all();
+
set_dirty_tracking(0);
while ((bmds = QSIMPLEQ_FIRST(&block_mig_state.bmds_list)) != NULL) {
--
1.7.6.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-09-25 13:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-25 13:53 [Qemu-devel] [PATCH] block-migration: Flush requests in blk_mig_cleanup Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).