From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Dong Xu Wang <wdongxu@linux.vnet.ibm.com>,
armbru@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [RFC v2 0/7] replace QEMUOptionParameter with QemuOpts parser
Date: Thu, 27 Sep 2012 13:14:18 +0800 [thread overview]
Message-ID: <1348722865-20564-1-git-send-email-wdongxu@linux.vnet.ibm.com> (raw)
This is still a RFC, I cut some block image formats to simplify
the exploring.
patch 1-3 are from Luiz, added Markus's comments, discussion could be found here:
http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html
patch 4-5: because qemu_opts_create can not fail while id is null, so create
function qemu_opts_create_nofail and use it.
patch 6: create function qemu_opt_set_number, like qemu_opt_set_bool.
patch 7: remove QEMUOptionParameter and use QemuOpts parser.
v1->v2:
1) add Luiz's patches.
2) create qemu_opt_set_number() and qemu_opts_create_nofail() functions.
3) add QemuOptsList map to drivers.
4) use original opts parser, not creating new ones.
5) fix other bugs.
Dong Xu Wang (7):
qemu-option: qemu_opt_set_bool(): fix code duplication
qemu-option: opt_set(): split it up into more functions
qemu-option: qemu_opts_validate(): fix duplicated code
introduce qemu_opts_create_nofail function
use qemu_opts_create_nofail
create new function: qemu_opt_set_number
remove QEMUOptionParameter
block.c | 88 +++++-----
block.h | 5 +-
block/Makefile.objs | 9 +-
block/qcow2.c | 175 ++++++++++---------
block/raw-posix.c | 68 ++++----
block/raw.c | 31 ++--
block_int.h | 6 +-
blockdev.c | 2 +-
hw/watchdog.c | 2 +-
qemu-config.c | 7 +-
qemu-img.c | 60 +++----
qemu-option.c | 501 ++++++++++++++++-----------------------------------
qemu-option.h | 47 +----
qemu-sockets.c | 8 +-
vl.c | 6 +-
15 files changed, 401 insertions(+), 614 deletions(-)
next reply other threads:[~2012-09-27 5:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 5:14 Dong Xu Wang [this message]
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 1/7] qemu-option: qemu_opt_set_bool(): fix code duplication Dong Xu Wang
2012-09-27 11:55 ` Paolo Bonzini
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 2/7] qemu-option: opt_set(): split it up into more functions Dong Xu Wang
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 3/7] qemu-option: qemu_opts_validate(): fix duplicated code Dong Xu Wang
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 4/7] introduce qemu_opts_create_nofail function Dong Xu Wang
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 5/7] use qemu_opts_create_nofail Dong Xu Wang
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 6/7] create new function: qemu_opt_set_number Dong Xu Wang
2012-09-27 11:56 ` Paolo Bonzini
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 7/7] remove QEMUOptionParameter Dong Xu Wang
2012-09-27 12:03 ` Paolo Bonzini
2012-09-28 6:42 ` Dong Xu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348722865-20564-1-git-send-email-wdongxu@linux.vnet.ibm.com \
--to=wdongxu@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).