qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: QEMU-devel <qemu-devel@nongnu.org>,
	Stefano Stabellini <stefano.stabellini@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	Xen Devel <xen-devel@lists.xen.org>
Subject: [Qemu-devel] [PATCH V4 5/5] xen: Set the vram dirty when an error occur.
Date: Thu, 27 Sep 2012 12:12:40 +0100	[thread overview]
Message-ID: <1348744360-2989-6-git-send-email-anthony.perard@citrix.com> (raw)
In-Reply-To: <1348744360-2989-1-git-send-email-anthony.perard@citrix.com>

If the call to xc_hvm_track_dirty_vram() fails, then we set dirtybit on all the
video ram. This case happens during migration.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 xen-all.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen-all.c b/xen-all.c
index b11542c..e6308be 100644
--- a/xen-all.c
+++ b/xen-all.c
@@ -507,7 +507,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state,
                                  bitmap);
     if (rc < 0) {
         if (rc != -ENODATA) {
-            fprintf(stderr, "xen: track_dirty_vram failed (0x" TARGET_FMT_plx
+            memory_region_set_dirty(framebuffer, 0, size);
+            DPRINTF("xen: track_dirty_vram failed (0x" TARGET_FMT_plx
                     ", 0x" TARGET_FMT_plx "): %s\n",
                     start_addr, start_addr + size, strerror(-rc));
         }
-- 
Anthony PERARD

  parent reply	other threads:[~2012-09-27 11:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27 11:12 [Qemu-devel] [PATCH V4 0/5] Xen, introducing dirty log for migration Anthony PERARD
2012-09-27 11:12 ` [Qemu-devel] [PATCH V4 1/5] QMP, Introduce xen-set-global-dirty-log command Anthony PERARD
2012-09-27 11:12 ` [Qemu-devel] [PATCH V4 2/5] xen: Introduce xen_modified_memory Anthony PERARD
2012-10-01 10:32   ` Stefano Stabellini
2012-09-27 11:12 ` [Qemu-devel] [PATCH V4 3/5] exec: Introduce helper to set dirty flags Anthony PERARD
2012-09-27 11:12 ` [Qemu-devel] [PATCH V4 4/5] exec, memory: Call to xen_modified_memory Anthony PERARD
2012-10-01 10:36   ` Stefano Stabellini
2012-10-02 10:25     ` Avi Kivity
2012-10-02 16:16       ` Anthony PERARD
2012-10-02 16:20         ` Avi Kivity
2012-09-27 11:12 ` Anthony PERARD [this message]
2012-10-01 10:33   ` [Qemu-devel] [PATCH V4 5/5] xen: Set the vram dirty when an error occur Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348744360-2989-6-git-send-email-anthony.perard@citrix.com \
    --to=anthony.perard@citrix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).