* [Qemu-devel] [PATCH] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code
@ 2012-09-27 13:55 Peter Maydell
2012-09-27 19:57 ` Aurelien Jarno
2012-10-05 12:21 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 2 replies; 5+ messages in thread
From: Peter Maydell @ 2012-09-27 13:55 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, patches
Use the recently introduced tcg_out_mov_reg() function rather than
the equivalent inline code.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
This is a minor follow-on cleanup patch after commit 9716ef3b1.
tcg/arm/tcg-target.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
index 2bad0a2..5e8dbdd 100644
--- a/tcg/arm/tcg-target.c
+++ b/tcg/arm/tcg-target.c
@@ -1197,20 +1197,11 @@ static inline void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, int opc)
case 1:
case 2:
default:
- if (data_reg != TCG_REG_R0) {
- tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
- data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0));
- }
+ tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0);
break;
case 3:
- if (data_reg != TCG_REG_R0) {
- tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
- data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0));
- }
- if (data_reg2 != TCG_REG_R1) {
- tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
- data_reg2, 0, TCG_REG_R1, SHIFT_IMM_LSL(0));
- }
+ tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0);
+ tcg_out_mov_reg(s, COND_AL, data_reg2, TCG_REG_R1);
break;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code
2012-09-27 13:55 [Qemu-devel] [PATCH] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code Peter Maydell
@ 2012-09-27 19:57 ` Aurelien Jarno
2012-10-05 12:21 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
1 sibling, 0 replies; 5+ messages in thread
From: Aurelien Jarno @ 2012-09-27 19:57 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
On Thu, Sep 27, 2012 at 02:55:43PM +0100, Peter Maydell wrote:
> Use the recently introduced tcg_out_mov_reg() function rather than
> the equivalent inline code.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This is a minor follow-on cleanup patch after commit 9716ef3b1.
>
> tcg/arm/tcg-target.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
> index 2bad0a2..5e8dbdd 100644
> --- a/tcg/arm/tcg-target.c
> +++ b/tcg/arm/tcg-target.c
> @@ -1197,20 +1197,11 @@ static inline void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, int opc)
> case 1:
> case 2:
> default:
> - if (data_reg != TCG_REG_R0) {
> - tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
> - data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0));
> - }
> + tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0);
> break;
> case 3:
> - if (data_reg != TCG_REG_R0) {
> - tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
> - data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0));
> - }
> - if (data_reg2 != TCG_REG_R1) {
> - tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
> - data_reg2, 0, TCG_REG_R1, SHIFT_IMM_LSL(0));
> - }
> + tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0);
> + tcg_out_mov_reg(s, COND_AL, data_reg2, TCG_REG_R1);
> break;
> }
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code
2012-09-27 13:55 [Qemu-devel] [PATCH] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code Peter Maydell
2012-09-27 19:57 ` Aurelien Jarno
@ 2012-10-05 12:21 ` Stefan Hajnoczi
1 sibling, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2012-10-05 12:21 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
On Thu, Sep 27, 2012 at 02:55:43PM +0100, Peter Maydell wrote:
> Use the recently introduced tcg_out_mov_reg() function rather than
> the equivalent inline code.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This is a minor follow-on cleanup patch after commit 9716ef3b1.
>
> tcg/arm/tcg-target.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code
@ 2012-09-28 15:05 Peter Maydell
2012-09-28 15:17 ` Peter Maydell
0 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2012-09-28 15:05 UTC (permalink / raw)
To: qemu-devel; +Cc: patches, Alexander Graf, Aurelien Jarno, Richard Henderson
Use the recently introduced tcg_out_mov_reg() function rather than
the equivalent inline code.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
This is a minor follow-on cleanup patch after commit 9716ef3b1.
tcg/arm/tcg-target.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
index 2bad0a2..5e8dbdd 100644
--- a/tcg/arm/tcg-target.c
+++ b/tcg/arm/tcg-target.c
@@ -1197,20 +1197,11 @@ static inline void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, int opc)
case 1:
case 2:
default:
- if (data_reg != TCG_REG_R0) {
- tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
- data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0));
- }
+ tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0);
break;
case 3:
- if (data_reg != TCG_REG_R0) {
- tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
- data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0));
- }
- if (data_reg2 != TCG_REG_R1) {
- tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
- data_reg2, 0, TCG_REG_R1, SHIFT_IMM_LSL(0));
- }
+ tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0);
+ tcg_out_mov_reg(s, COND_AL, data_reg2, TCG_REG_R1);
break;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code
2012-09-28 15:05 [Qemu-devel] " Peter Maydell
@ 2012-09-28 15:17 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2012-09-28 15:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Richard Henderson, Alexander Graf, Aurelien Jarno, patches
On 28 September 2012 16:05, Peter Maydell <peter.maydell@linaro.org> wrote:
> Use the recently introduced tcg_out_mov_reg() function rather than
> the equivalent inline code.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Whoops, used git send-email on wrong file; please ignore this email.
Correct patch should arrive shortly.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-05 12:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-27 13:55 [Qemu-devel] [PATCH] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code Peter Maydell
2012-09-27 19:57 ` Aurelien Jarno
2012-10-05 12:21 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2012-09-28 15:05 [Qemu-devel] " Peter Maydell
2012-09-28 15:17 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).