From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THHql-0006vl-UT for qemu-devel@nongnu.org; Thu, 27 Sep 2012 13:26:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THHqk-0005Yl-Pl for qemu-devel@nongnu.org; Thu, 27 Sep 2012 13:26:11 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:39647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THHqk-0004ys-HX for qemu-devel@nongnu.org; Thu, 27 Sep 2012 13:26:10 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp2so3912471pbb.4 for ; Thu, 27 Sep 2012 10:26:10 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Thu, 27 Sep 2012 10:19:56 -0700 Message-Id: <1348766397-20731-7-git-send-email-rth@twiddle.net> In-Reply-To: <1348766397-20731-1-git-send-email-rth@twiddle.net> References: <1348766397-20731-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH 6/7] tcg: Tidy brcond optimization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Aurelien Jarno Do the memset once. Don't reset_temp before doing so. Signed-off-by: Richard Henderson --- tcg/optimize.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index c1881fa..dfac877 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -771,22 +771,22 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, tmp = do_constant_folding_cond(op, args[0], args[1], args[2]); if (tmp != 2) { if (tmp) { - memset(temps, 0, nb_temps * sizeof(struct tcg_temp_info)); gen_opc_buf[op_index] = INDEX_op_br; gen_args[0] = args[3]; gen_args += 1; } else { gen_opc_buf[op_index] = INDEX_op_nop; + args += 4; + break; } } else { - memset(temps, 0, nb_temps * sizeof(struct tcg_temp_info)); - reset_temp(args[0]); gen_args[0] = args[0]; gen_args[1] = args[1]; gen_args[2] = args[2]; gen_args[3] = args[3]; gen_args += 4; } + memset(temps, 0, nb_temps * sizeof(struct tcg_temp_info)); args += 4; break; CASE_OP_32_64(movcond): -- 1.7.11.4