From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THOdu-0003K0-6Y for qemu-devel@nongnu.org; Thu, 27 Sep 2012 20:41:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THOdt-0001N8-2K for qemu-devel@nongnu.org; Thu, 27 Sep 2012 20:41:22 -0400 Received: from mail-da0-f45.google.com ([209.85.210.45]:42812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THOds-0001Mv-Rz for qemu-devel@nongnu.org; Thu, 27 Sep 2012 20:41:20 -0400 Received: by dadn15 with SMTP id n15so520916dad.4 for ; Thu, 27 Sep 2012 17:41:19 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Thu, 27 Sep 2012 17:41:15 -0700 Message-Id: <1348792875-27268-1-git-send-email-rth@twiddle.net> In-Reply-To: <1348785610-23418-1-git-send-email-rth@twiddle.net> References: <1348785610-23418-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH 106/147] target-s390: Convert SSKE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexander Graf Signed-off-by: Richard Henderson --- target-s390x/helper.h | 2 +- target-s390x/insn-data.def | 2 ++ target-s390x/mem_helper.c | 2 +- target-s390x/translate.c | 18 +++++++----------- 4 files changed, 11 insertions(+), 13 deletions(-) diff --git a/target-s390x/helper.h b/target-s390x/helper.h index 28aabe7..3b437c0 100644 --- a/target-s390x/helper.h +++ b/target-s390x/helper.h @@ -99,7 +99,7 @@ DEF_HELPER_4(stctl, void, env, i32, i64, i32) DEF_HELPER_4(stctg, void, env, i32, i64, i32) DEF_HELPER_FLAGS_2(tprot, TCG_CALL_CONST, i32, i64, i64) DEF_HELPER_FLAGS_2(iske, TCG_CALL_PURE|TCG_CALL_CONST, i64, env, i64) -DEF_HELPER_FLAGS_3(sske, TCG_CALL_CONST, void, env, i32, i64) +DEF_HELPER_FLAGS_3(sske, TCG_CALL_CONST, void, env, i64, i64) DEF_HELPER_FLAGS_3(rrbe, TCG_CALL_CONST, i32, env, i32, i64) DEF_HELPER_3(csp, i32, env, i32, i32) DEF_HELPER_4(mvcs, i32, env, i64, i64, i64) diff --git a/target-s390x/insn-data.def b/target-s390x/insn-data.def index 87daec1..f554c1b 100644 --- a/target-s390x/insn-data.def +++ b/target-s390x/insn-data.def @@ -650,6 +650,8 @@ C(0xb210, SPX, S, Z, 0, m2_32u, 0, 0, spx, 0) /* SET PSW KEY FROM ADDRESS */ C(0xb20a, SPKA, S, Z, 0, a2, 0, 0, spka, 0) +/* SET STORAGE KEY EXTENDED */ + C(0xb22b, SSKE, RRF_c, Z, r1_o, r2_o, 0, 0, sske, 0) /* SET SYSTEM MASK */ C(0x8000, SSM, S, Z, 0, m2_8u, 0, 0, ssm, 0) /* SIGNAL PROCESSOR */ diff --git a/target-s390x/mem_helper.c b/target-s390x/mem_helper.c index 8522140..c6f7741 100644 --- a/target-s390x/mem_helper.c +++ b/target-s390x/mem_helper.c @@ -952,7 +952,7 @@ uint64_t HELPER(iske)(CPUS390XState *env, uint64_t r2) } /* set storage key extended */ -void HELPER(sske)(CPUS390XState *env, uint32_t r1, uint64_t r2) +void HELPER(sske)(CPUS390XState *env, uint64_t r1, uint64_t r2) { uint64_t addr = get_address(env, 0, 0, r2); diff --git a/target-s390x/translate.c b/target-s390x/translate.c index bf746c7..68f5b3c 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@ -1045,17 +1045,6 @@ static void disas_b2(CPUS390XState *env, DisasContext *s, int op, tcg_temp_free_i32(tmp32_1); tcg_temp_free_i64(tmp); break; - case 0x2b: /* SSKE R1,R2 [RRE] */ - /* Set Storage Key Extended */ - check_privileged(s); - r1 = (insn >> 4) & 0xf; - r2 = insn & 0xf; - tmp32_1 = load_reg32(r1); - tmp = load_reg(r2); - gen_helper_sske(cpu_env, tmp32_1, tmp); - tcg_temp_free_i32(tmp32_1); - tcg_temp_free_i64(tmp); - break; case 0x34: /* STCH ? */ /* Store Subchannel */ check_privileged(s); @@ -2831,6 +2820,13 @@ static ExitStatus op_spka(DisasContext *s, DisasOps *o) return NO_EXIT; } +static ExitStatus op_sske(DisasContext *s, DisasOps *o) +{ + check_privileged(s); + gen_helper_sske(cpu_env, o->in1, o->in2); + return NO_EXIT; +} + static ExitStatus op_ssm(DisasContext *s, DisasOps *o) { check_privileged(s); -- 1.7.11.4