From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THdhf-00087l-61 for qemu-devel@nongnu.org; Fri, 28 Sep 2012 12:46:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THdhe-0000c3-1K for qemu-devel@nongnu.org; Fri, 28 Sep 2012 12:46:15 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:37943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THdhd-0000UM-Q7 for qemu-devel@nongnu.org; Fri, 28 Sep 2012 12:46:13 -0400 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 28 Sep 2012 10:46:03 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id CF6971FF0043 for ; Fri, 28 Sep 2012 10:45:56 -0600 (MDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8SGjnwK117134 for ; Fri, 28 Sep 2012 10:45:50 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8SGjdFv024479 for ; Fri, 28 Sep 2012 10:45:44 -0600 From: Richa Marwaha Date: Fri, 28 Sep 2012 12:45:35 -0400 Message-Id: <1348850735-21903-1-git-send-email-rmarwah@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH] Removing O_LARGEFILE from block layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: coreyb@linux.vnet.ibm.com QEMU by default configures -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE so there is not need to mention O_LARGEFILE in the block layer. Signed-off-by: Richa Marwaha --- block/raw-posix.c | 2 +- block/vdi.c | 2 +- block/vmdk.c | 6 +++--- block/vvfat.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 28d439f..43e3936 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -965,7 +965,7 @@ static int hdev_open(BlockDriverState *bs, const char *filename, int flags) if ( bsdPath[ 0 ] != '\0' ) { strcat(bsdPath,"s0"); /* some CDs don't have a partition 0 */ - fd = qemu_open(bsdPath, O_RDONLY | O_BINARY | O_LARGEFILE); + fd = qemu_open(bsdPath, O_RDONLY | O_BINARY); if (fd < 0) { bsdPath[strlen(bsdPath)-1] = '1'; } else { diff --git a/block/vdi.c b/block/vdi.c index f35b12e..c70b38b 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -659,7 +659,7 @@ static int vdi_create(const char *filename, QEMUOptionParameter *options) } fd = qemu_open(filename, - O_WRONLY | O_CREAT | O_TRUNC | O_BINARY | O_LARGEFILE, + O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0644); if (fd < 0) { return -errno; diff --git a/block/vmdk.c b/block/vmdk.c index f2e861b..c673de3 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1252,7 +1252,7 @@ static int vmdk_create_extent(const char *filename, int64_t filesize, uint32_t tmp, magic, grains, gd_size, gt_size, gt_count; fd = qemu_open(filename, - O_WRONLY | O_CREAT | O_TRUNC | O_BINARY | O_LARGEFILE, + O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0644); if (fd < 0) { return -errno; @@ -1574,11 +1574,11 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options) total_size / (int64_t)(63 * 16 * 512)); if (split || flat) { fd = qemu_open(filename, - O_WRONLY | O_CREAT | O_TRUNC | O_BINARY | O_LARGEFILE, + O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0644); } else { fd = qemu_open(filename, - O_WRONLY | O_BINARY | O_LARGEFILE, + O_WRONLY | O_BINARY, 0644); } if (fd < 0) { diff --git a/block/vvfat.c b/block/vvfat.c index 59d3c5b..24cbc71 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -1162,7 +1162,7 @@ static int open_file(BDRVVVFATState* s,mapping_t* mapping) if(!s->current_mapping || strcmp(s->current_mapping->path,mapping->path)) { /* open file */ - int fd = qemu_open(mapping->path, O_RDONLY | O_BINARY | O_LARGEFILE); + int fd = qemu_open(mapping->path, O_RDONLY | O_BINARY); if(fd<0) return -1; vvfat_close_current_file(s); -- 1.7.0.4