* [Qemu-devel] [PATCH] trivial fix of inet_listen() parameter
@ 2012-09-29 9:32 Amos Kong
2012-09-29 20:57 ` Igor Mammedov
0 siblings, 1 reply; 2+ messages in thread
From: Amos Kong @ 2012-09-29 9:32 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, aliguori, Amos Kong, mdroth
.. int inet_listen(const char *str, char *ostr, int olen,
.. int socktype, int port_offset, Error **errp)
Here 'ostr' is NULL, so change 'olen' to zero.
Signed-off-by: Amos Kong <akong@redhat.com>
---
migration-tcp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/migration-tcp.c b/migration-tcp.c
index a15c2b8..34d6d89 100644
--- a/migration-tcp.c
+++ b/migration-tcp.c
@@ -123,7 +123,7 @@ int tcp_start_incoming_migration(const char *host_port, Error **errp)
{
int s;
- s = inet_listen(host_port, NULL, 256, SOCK_STREAM, 0, errp);
+ s = inet_listen(host_port, NULL, 0, SOCK_STREAM, 0, errp);
if (s < 0) {
return -1;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] trivial fix of inet_listen() parameter
2012-09-29 9:32 [Qemu-devel] [PATCH] trivial fix of inet_listen() parameter Amos Kong
@ 2012-09-29 20:57 ` Igor Mammedov
0 siblings, 0 replies; 2+ messages in thread
From: Igor Mammedov @ 2012-09-29 20:57 UTC (permalink / raw)
To: Amos Kong; +Cc: stefanha, aliguori, qemu-devel, mdroth
On Sat, 29 Sep 2012 17:32:31 +0800
Amos Kong <akong@redhat.com> wrote:
> .. int inet_listen(const char *str, char *ostr, int olen,
> .. int socktype, int port_offset, Error **errp)
>
> Here 'ostr' is NULL, so change 'olen' to zero.
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> migration-tcp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/migration-tcp.c b/migration-tcp.c
> index a15c2b8..34d6d89 100644
> --- a/migration-tcp.c
> +++ b/migration-tcp.c
> @@ -123,7 +123,7 @@ int tcp_start_incoming_migration(const char *host_port, Error **errp)
> {
> int s;
>
> - s = inet_listen(host_port, NULL, 256, SOCK_STREAM, 0, errp);
> + s = inet_listen(host_port, NULL, 0, SOCK_STREAM, 0, errp);
>
> if (s < 0) {
> return -1;
> --
> 1.7.1
>
Reviewed-By: Igor Mammedov <imammedo@redhat.com>
--
Regards,
Igor
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-29 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-29 9:32 [Qemu-devel] [PATCH] trivial fix of inet_listen() parameter Amos Kong
2012-09-29 20:57 ` Igor Mammedov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).