qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Alex Barcelo <abarcelo@ac.upc.edu>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
Date: Mon, 01 Oct 2012 12:49:49 -0600	[thread overview]
Message-ID: <1349117389.28860.299.camel@bling.home> (raw)
In-Reply-To: <1349116911-18550-1-git-send-email-aliguori@us.ibm.com>

On Mon, 2012-10-01 at 13:41 -0500, Anthony Liguori wrote:
> We cannot cast directly from pointer to uint64.
> 
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Alex Barcelo <abarcelo@ac.upc.edu>
> Reported-by: Alex Barcelo <abarcelo@ac.upc.edu>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  hw/vfio_pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c
> index a24558a..a1eeced 100644
> --- a/hw/vfio_pci.c
> +++ b/hw/vfio_pci.c
> @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, target_phys_addr_t iova,
>      struct vfio_iommu_type1_dma_map map = {
>          .argsz = sizeof(map),
>          .flags = VFIO_DMA_MAP_FLAG_READ,
> -        .vaddr = (__u64)vaddr,
> +        .vaddr = (__u64)(intptr_t)vaddr,
>          .iova = iova,
>          .size = size,
>      };

Thanks Anthony

Acked-by: Alex Williamson <alex.williamson@redhat.com>

  reply	other threads:[~2012-10-01 18:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-01 18:41 [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems Anthony Liguori
2012-10-01 18:49 ` Alex Williamson [this message]
2012-10-02  6:11   ` Paolo Bonzini
2012-10-02 14:37     ` Alex Williamson
2012-10-02 15:03     ` Anthony Liguori
2012-10-01 19:27 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349117389.28860.299.camel@bling.home \
    --to=alex.williamson@redhat.com \
    --cc=abarcelo@ac.upc.edu \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).