From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1TIl40-0005Sd-Sj
	for qemu-devel@nongnu.org; Mon, 01 Oct 2012 14:50:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1TIl3w-0005Xl-TY
	for qemu-devel@nongnu.org; Mon, 01 Oct 2012 14:49:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46095)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1TIl3w-0005XY-KG
	for qemu-devel@nongnu.org; Mon, 01 Oct 2012 14:49:52 -0400
Message-ID: <1349117389.28860.299.camel@bling.home>
From: Alex Williamson <alex.williamson@redhat.com>
Date: Mon, 01 Oct 2012 12:49:49 -0600
In-Reply-To: <1349116911-18550-1-git-send-email-aliguori@us.ibm.com>
References: <1349116911-18550-1-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Alex Barcelo <abarcelo@ac.upc.edu>, qemu-devel@nongnu.org

On Mon, 2012-10-01 at 13:41 -0500, Anthony Liguori wrote:
> We cannot cast directly from pointer to uint64.
> 
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Alex Barcelo <abarcelo@ac.upc.edu>
> Reported-by: Alex Barcelo <abarcelo@ac.upc.edu>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  hw/vfio_pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c
> index a24558a..a1eeced 100644
> --- a/hw/vfio_pci.c
> +++ b/hw/vfio_pci.c
> @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, target_phys_addr_t iova,
>      struct vfio_iommu_type1_dma_map map = {
>          .argsz = sizeof(map),
>          .flags = VFIO_DMA_MAP_FLAG_READ,
> -        .vaddr = (__u64)vaddr,
> +        .vaddr = (__u64)(intptr_t)vaddr,
>          .iova = iova,
>          .size = size,
>      };

Thanks Anthony

Acked-by: Alex Williamson <alex.williamson@redhat.com>